FUDforum - خوراک RDF
http://fudforum.org/forum/index.php
Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=166924&th=120389#msg_166924
When the NNTP import process hits certain posts, it is thrown into an infinite loop. the php and mysql processes go to 100% and the import never proceeds any further. Next time the cron job comes round, another php process is started, which immediately goes into an infinite loop. After a few minutes, I end up with hundreds of PHP processes, and a virtually unusable server. The only way out is to disable the cron job and "killall php" to recover control of the server.
My investigations so far seem to point to it being something to do with 'umlauted' characters in the User Name portion of the 'From:' field. Normally, FUDforum just truncates the name at the first umlauted character, but imports the post successfully. However, when combined with other aspects of the 'From:' field structure (which I have yet to establish), and if the e-mail address has not been seen before by FUDforum, this will cause the php script to enter the infinite loop.
I can provide an example of a 'From:' field which reliably triggers the bug if required, but I cannot post this on the public forum.
However, this is not the only trigger! Some other characters or character sequences occurring within the message can also trigger this problem, as I was hitting this problem with some Uuencoded attachments. Some detailed further investigation is needed.
I am seeing the exact same effect on two different servers:
First server is running Red Hat Enterprise Linux Server release 5.6 (Tikanga), PHP version 5.3.3, MySQL version 5.0.77.
Other server is running Debian 6.0.4, PHP version 5.3.3, MySQL version 5.1.49
In both cases, the NNTP server is running locally on the same box, so FUDforum is talking to 127.0.0.1 to sync newsgroups. First server is running INN 2.4.3, other server is running INN 2.5.2, but it seems to be specific posts in the news spool that are triggering the bug in FUDforum, rather than the NNTP server itself.
]]>Multitool2012-03-30T14:59:43-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=166929&th=120389#msg_166929
The bug was introduced at some stage between 3.0.1 and 3.0.2.
]]>Multitool2012-03-31T10:20:32-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=166945&th=120389#msg_166945
I've built the forum on 3.0.1 for the time being, and all is working, but it would be nice to upgrade to the latest release if possible.
]]>Multitool2012-04-06T13:45:40-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=166965&th=120389#msg_166965
Mail me a problem message (with full headers), and I'll look into it.
]]>naudefj2012-04-10T12:51:04-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=166986&th=120389#msg_166986
I have now uninstalled 3.0.3 as we're running with 3.0.1 now to avoid this bug, but I will set up an instance of 3.0.3 and send you a few example messages that trigger the bug.
However, I think if you set FUDforum to mirror any newsgroup containing split attachments, you will hit the bug very soon. It seems to be certain text strings occurring within the message headers or body that are triggering it.
]]>Multitool2012-04-13T12:23:30-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=167033&th=120389#msg_167033
How do I get in contact with you? I can't see an option to send a Private Message?
Usernames containing "invalid" characters are still truncated, but at least the import script doesn't crash now
]]>Multitool2012-05-18T11:03:51-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3 - FIXED!
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=167881&th=120389#msg_167881
Multitool wrote on Fri, 18 May 2012 12:03
Just to update in case anyone else was tracking this, Frank has produced a patch that fixes the infinite loop issue.
Usernames containing "invalid" characters are still truncated, but at least the import script doesn't crash now
Unfortunately this fix breaks the code that appends [n] to the end of duplicate usernames.
The next number is appended after the previous number, so instead of "James[5]" the name becomes "James[1][2][3][4][5]".
If there are a lot of duplicates, or the original name is long, this ends up making the string exceed the max length, gets truncated, and add_user fails with a duplicate entry.
]]>Multitool2012-10-31T12:09:49-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=167892&th=120389#msg_167892
]]>Multitool2012-11-01T18:31:35-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=167893&th=120389#msg_167893
Can you commit it or should I?]]>naudefj2012-11-02T06:10:24-00:00Re: Serious NNTP Import bug in FUDforum 3.0.3
http://fudforum.org/forum/index.phpindex.php?t=rview&goto=167894&th=120389#msg_167894
naudefj wrote on Fri, 02 November 2012 06:10
Great, thanks!
Can you commit it or should I?
Can you commit it? I don't have the necessary accounts