FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum » FUDforum Installation Issues » path_info: tabs broken after upgrade (path_info url`s not set after upgrade to 2.8.0)
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
path_info: tabs broken after upgrade [message #158723] Sun, 15 March 2009 16:23 Go to next message
!alex is currently offline  !alex   Austria
Messages: 23
Registered: February 2004
Location: germany
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
After upgrading from 2.6.5 -> 2.7.7 -> 2.8.0 the links in the tabs don't work anymore for path_info based theme.

Instad of index.php/pdm/ (path_info url) index.php?t=pmsg is set as target, also for the other tabs.

I went through the templates etc. for a while but wasn't able to figure out where to change it, also compared tabs.inc.t with the version from 2.6.5 - no success Sad

For me also a set of rules for mod_rewrite that redirects default-url`s to url`s that work with path_info would be fine,
this could keep me (and others, having problems with path_info ur`s) from fixing it on every single place Wink

Best Regards,
Alex

[Updated on: Sun, 15 March 2009 16:25]

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158724 is a reply to message #158723] Sun, 15 March 2009 16:41 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3628
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Hi Alex,

I'm also using the PATH_INFO theme and don't see any default URLs. Please check:

1) if "Use PATH_INFO style URLs" is set to true in the Admin Control Panel -> Global Configuration; and

2) if you are using the PATH_INFO theme in the Admin Control Panel -> Theme Manager.

Best regards.

Frank
Re: path_info: tabs broken after upgrade [message #158725 is a reply to message #158723] Sun, 15 March 2009 16:54 Go to previous messageGo to next message
!alex is currently offline  !alex   Austria
Messages: 23
Registered: February 2004
Location: germany
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Hi Frank,
well, both is set, but i wonder why only on the tabs the url`s are not set the way they should..

I also had a look at forum/src/tabs.inc.t where the url`s are set:
              foreach($tablist as $tab_name => $tab) {
                        $tab_url = '{ROOT}?t='.$tab.(s ? '&S='.s : '');
                        if ($tab == 'referals') {
                                if (!($FUD_OPT_2 & 8192)) {
                                        continue;
                                }
                                $tab_url .= '&id='._uid;
                        } else if ($tab == 'showposts') {
                                $tab_url .= '&id='._uid;
                        }
                        $tabs .= $pg == $tab ? '{TEMPLATE: active_tab}' : '{TEMPLATE: inactive_tab}';
                }

                $tabs = '{TEMPLATE: tablist}';


For me this might be the place a clean path_info url should be written instead of _GET based url's ...

Alex
Re: path_info: tabs broken after upgrade [message #158726 is a reply to message #158725] Sun, 15 March 2009 17:12 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3628
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
OK, I understand the problem and can simulate it on my forum as well. Will start working on a patch tomorrow.
Re: path_info: tabs broken after upgrade [message #158727 is a reply to message #158723] Sun, 15 March 2009 17:23 Go to previous messageGo to next message
!alex is currently offline  !alex   Austria
Messages: 23
Registered: February 2004
Location: germany
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Thanks,
i`m currently working on a mod_rewrite set - will publish it here for those who don't want to patch ...

Alex

edit:
Not nice but works for the broken tabs ...
b.t.w.: translations _GET / path-info can be found in forum/src/users.inc.t Wink

RewriteCond %{QUERY_STRING} t=pmsg
RewriteRule  ^(.*)$ /forum/index.php/pdm/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=uc
RewriteRule  ^(.*)$ /forum/index.php/uc/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=register
RewriteRule  ^(.*)$ /forum/index.php/re/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=subscribed
RewriteRule  ^(.*)$ /forum/index.php/sl/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=buddy_list
RewriteRule  ^(.*)$ /forum/index.php/bl/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=ignore_list
RewriteRule  ^(.*)$ /forum/index.php/il/$2? [R=301,L]

RewriteCond %{QUERY_STRING} t=showposts&id=([0-9]+)
RewriteRule  ^(.*)$ /forum/index.php/sp/%1/$2? [R=301,L]

[Updated on: Sun, 15 March 2009 17:36]

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158728 is a reply to message #158723] Sun, 15 March 2009 17:46 Go to previous messageGo to next message
!alex is currently offline  !alex   Austria
Messages: 23
Registered: February 2004
Location: germany
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
There`s more problems on my install,
"Message Navigator" and "User Search" Forms is what i found, too ...
fixed it both with rewrite-rules for the beginning ...

Alex

[Updated on: Sun, 15 March 2009 18:02]

Report message to a moderator

Re: path_info: tabs broken after upgrade [message #158729 is a reply to message #158728] Mon, 16 March 2009 01:26 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3628
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
On second thought, search engines cannot see those links (only logged-in users can). So, it is really necessary to use PATH_INFO url's everywhere?
Re: path_info: tabs broken after upgrade [message #158730 is a reply to message #158723] Mon, 16 March 2009 05:57 Go to previous message
!alex is currently offline  !alex   Austria
Messages: 23
Registered: February 2004
Location: germany
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Hello,
no, not really, but users should be able to use those functions of the forum Wink

for me the solution with mod_rewrite works, also for the users, but i think this should be fixed in the forum-scripts ...

Alex
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Upgrading from 2.7.7 to 2.8.0
Next Topic: cosmetic / security concern with step 5
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Mon Dec 11 04:29:48 EST 2017

Total time taken to generate the page: 0.00751 seconds