FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » Stray HTML Table tag
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
Stray HTML Table tag [message #167478] Fri, 29 June 2012 05:55 Go to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
Using Fudforum 3.0.3

File: FUDforumData\thm\default\tmpl\draw_forum_list.tmpl
Line: Line 23, </table> tag.

Should the table tag be within the endif block that comes just before it or somewhere else?

The reason I noticed this is because I was trying to apply a background to the very first table that encompasses the whole forum.
I applied a background and it worked fine on the main page but when I went into thread view,the background ended right after the forum path due to a </table> tag.
index.php?t=getfile&id=6291&private=0
Upon looking at the html source, I saw a stray </table> tag at the end.

To fix my problem I did the following:
In File: FUDforumData\thm\default\tmpl\thread.tmpl
Line 30, I added <table>
index.php?t=getfile&id=6290&private=0
This seemed to have fixed it.

If I moved the </table> in draw_forum_list.tmpl within the endif tag, it did weird things to my main forum page.

I may be wrong......may be due to the many other modification I made...but please check/confirm.
Thanks.

  • Attachment: after.png
    (Size: 39.67KB, Downloaded 482 times)
  • Attachment: before.png
    (Size: 37.98KB, Downloaded 488 times)
Re: Stray HTML Table tag [message #167481 is a reply to message #167478] Fri, 29 June 2012 09:37 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Looks like a HTML/template bug. Nothing serious, but we will have to fix it.
Re: Stray HTML Table tag [message #167482 is a reply to message #167481] Fri, 29 June 2012 13:18 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Please test this patch and let us know if it solves the problem:
http://fudforum.svn.sourceforge.net/fudforum/?rev=5523&view=rev
Re: Stray HTML Table tag [message #167485 is a reply to message #167482] Sun, 01 July 2012 01:46 Go to previous messageGo to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
Thanks..will try it after the weekend... Smile
Re: Stray HTML Table tag [message #167491 is a reply to message #167485] Mon, 02 July 2012 06:03 Go to previous messageGo to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
Seems to have fixed it...
Looked at genned html source as well and looks like the stray table tag is not there..

thanks Smile

Cheers!
Re: Stray HTML Table tag [message #167496 is a reply to message #167491] Mon, 02 July 2012 12:33 Go to previous messageGo to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
Some More HTML Bugs..

File: FUDforumData\thm\default\tmpl\post.tmpl
Line: 146
<td class="GenText fb"><label for="thr_always_on_top">{MSG: post_always_on_top}</label</td>
should be:
<td class="GenText fb"><label for="thr_always_on_top">{MSG: post_always_on_top}</label></td>

File: FUDforumData\thm\default\tmpl\post_common.tmpl

Line: 103
{SECTION: post_icons}
<tr class="RowStyleA"><td class="vt GenText">{MSG: post_icons}</td><td>
<table border="0" cellspacing="0" cellpadding="2">
<tr>
<td class="GenText" colspan="{GVAR: POST_ICONS_PER_ROW}">
<input type="radio" name="msg_icon" value=""{IF: !$msg_icon} checked="checked"{ENDIF} />{MSG: post_no_icon}</td></tr>
{TEMPLATE-DATA: data}
</td>
</tr>
</table>

{SECTION: END}

The </table> should probably come before the </td></tr> tags...or some new tags need to be introduced...
{TEMPLATE-DATA: data} seems to create its own <tr><td></td></tr> tags...
Re: Stray HTML Table tag [message #167497 is a reply to message #167496] Mon, 02 July 2012 13:32 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Well spotted! I'll apply your fixes ASAP. You are obviously a very talented designer.
Re: Stray HTML Table tag [message #167498 is a reply to message #167497] Mon, 02 July 2012 14:25 Go to previous messageGo to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
Thanks for the fix...and for the flattery but hardly...just spotting them as I try to go about applying small changes of my own...Smile
Here is another one:

File:user_info_left\tmpl\drawmsg.tmpl
Line: 23
<table cellspacing="0" cellpadding="0" class="ContentTable"><tr class="MsgR2">{TEMPLATE-DATA: online_indicator}{TEMPLATE-DATA: user_link}{IF: !$hide_controls}{IF: $obj->disp_flag_cc && $GLOBALS['FUD_OPT_3'] & 524288}&nbsp;&nbsp;<img src="images/flags/{VAR: obj->disp_flag_cc}.png" border="0" width="16" height="11" title="{VAR: obj->flag_country}" alt="{VAR: obj->flag_country}"/>{ENDIFI}{IF: $obj->user_id}<br />{TEMPLATE-DATA: avatar}

should be:
<table cellspacing="0" cellpadding="0" class="ContentTable"><tr class="MsgR2"><td class="msgud">{TEMPLATE-DATA: online_indicator}{TEMPLATE-DATA: user_link}{IF: !$hide_controls}{IF: $obj->disp_flag_cc && $GLOBALS['FUD_OPT_3'] & 524288}&nbsp;&nbsp;<img src="images/flags/{VAR: obj->disp_flag_cc}.png" border="0" width="16" height="11" title="{VAR: obj->flag_country}" alt="{VAR: obj->flag_country}"/>{ENDIFI}{IF: $obj->user_id}</td></tr><tr>{TEMPLATE-DATA: avatar}</tr>

{TEMPLATE-DATA: online_indicator} should be within <td> since it does not create its own <tr>/<td> tags.
{TEMPLATE-DATA: avatar} creates <td> tags around itself but not <tr>.
Re: Stray HTML Table tag [message #167499 is a reply to message #167498] Mon, 02 July 2012 15:37 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Thanks again! You fix was committed at http://fudforum.svn.sourceforge.net/fudforum/?rev=5526&view=rev
Re: Stray HTML Table tag [message #167570 is a reply to message #167498] Sun, 15 July 2012 11:14 Go to previous messageGo to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
dennisp wrote on Mon, 02 July 2012 14:25
Thanks for the fix...and for the flattery but hardly...just spotting them as I try to go about applying small changes of my own...Smile
Here is another one:

File:user_info_left\tmpl\drawmsg.tmpl
Line: 23
<table cellspacing="0" cellpadding="0" class="ContentTable"><tr class="MsgR2">{TEMPLATE-DATA: online_indicator}{TEMPLATE-DATA: user_link}{IF: !$hide_controls}{IF: $obj->disp_flag_cc && $GLOBALS['FUD_OPT_3'] & 524288}&nbsp;&nbsp;<img src="images/flags/{VAR: obj->disp_flag_cc}.png" border="0" width="16" height="11" title="{VAR: obj->flag_country}" alt="{VAR: obj->flag_country}"/>{ENDIFI}{IF: $obj->user_id}<br />{TEMPLATE-DATA: avatar}

should be:
<table cellspacing="0" cellpadding="0" class="ContentTable"><tr class="MsgR2"><td class="msgud">{TEMPLATE-DATA: online_indicator}{TEMPLATE-DATA: user_link}{IF: !$hide_controls}{IF: $obj->disp_flag_cc && $GLOBALS['FUD_OPT_3'] & 524288}&nbsp;&nbsp;<img src="images/flags/{VAR: obj->disp_flag_cc}.png" border="0" width="16" height="11" title="{VAR: obj->flag_country}" alt="{VAR: obj->flag_country}"/>{ENDIFI}{IF: $obj->user_id}</td></tr><tr>{TEMPLATE-DATA: avatar}</tr>

{TEMPLATE-DATA: online_indicator} should be within <td> since it does not create its own <tr>/<td> tags.
{TEMPLATE-DATA: avatar} creates <td> tags around itself but not <tr>.


Similar to the above, drawpmsg.tmpl, also has the same html bug..im thinking in all the templates..

The file I checked was: user_left/drawpmsg.tmpl
Line 25:
<table cellspacing="0" cellpadding="0" class="ContentTable"><tr class="MsgR2">{TEMPLATE-DATA: online_indicator}{TEMPLATE: dpmsg_profile_link}{IF: !$mini}{IF: $obj->user_id}<br />{TEMPLATE-DATA: avatar}<tr class="MsgR2">

Should be
<table cellspacing="0" cellpadding="0" class="ContentTable"><tr class="MsgR2"><td class="msgud">{TEMPLATE-DATA: online_indicator}{TEMPLATE-DATA: user_link}{IF: !$hide_controls}{IF: $obj->disp_flag_cc && $GLOBALS['FUD_OPT_3'] & 524288}&nbsp;&nbsp;<img src="images/flags/{VAR: obj->disp_flag_cc}.png" border="0" width="16" height="11" title="{VAR: obj->flag_country}" alt="{VAR: obj->flag_country}"/>{ENDIFI}{IF: $obj->user_id}</td></tr><tr>{TEMPLATE-DATA: avatar}</tr><tr class="MsgR2">

[Updated on: Sun, 15 July 2012 11:15]

Report message to a moderator

Re: Stray HTML Table tag [message #167572 is a reply to message #167570] Sun, 15 July 2012 11:22 Go to previous messageGo to next message
dennisp is currently offline  dennisp   Taiwan
Messages: 49
Registered: December 2004
Location: Belize
Karma: 0
Member
add to buddy list
ignore all messages by this user
PS: If any one was wondering how I found these bugs

1) Editing the theme...once you edit and create a theme, you notice the html bug (if any), since sometimes the style or html property will not be applied properly.

2) Probably more easily through firefox's html source viewer. It highlights extra tags or misplaced tags in red. This is what really got me to realize why styles I was applying was not being applied and that it was due to an html bug. Without this, I would have spent much more time on my css trying to fix/wonder what was going on. Probably other source viewers do the same. Not sure.
Re: Stray HTML Table tag [message #167601 is a reply to message #167572] Mon, 23 July 2012 02:35 Go to previous message
NeXuS is currently offline  NeXuS
Messages: 121
Registered: July 2010
Location: South Korea
Karma: 5
Senior Member
Contributing Core Developer
add to buddy list
ignore all messages by this user
Thanks for the patches! The next release will be much easier to theme, or so I do hope... Smile
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Rate Topic tree view only
Next Topic: SQL fatal error
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Mon Oct 23 10:58:35 EDT 2017

Total time taken to generate the page: 0.01002 seconds