FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » NNTP Sync minor quirks
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
NNTP Sync minor quirks [message #159768] Sun, 21 June 2009 21:46 Go to next message
jcarter is currently offline  jcarter   United States
Messages: 25
Registered: August 2006
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
I recently upgraded to the latest version and have found several minor issues:

Version: 2.8.1

File: FUDForumData/include/nntp.inc

Around line 425:

if ( !strlen($msg_post->subject) ) {

The problem is that $msg_post->subject can be null which halts the script. I replaced it with:

if ( ($msg_post->subject == null) || !strlen($msg_post->subject) ) {


---------------------------------
Around line 455:

iconv_mime_encode("Subject:", $subject,

The problem is that the iconv_mime_encode function expects a keyword, and adds the colon, resulting in double colons and mangled subject thread titles. I changed it to :

iconv_mime_encode("Subject", $subject,

------------------------------------------

I posted these to {patches}.

Re: NNTP Sync minor quirks [message #159786 is a reply to message #159768] Wed, 24 June 2009 09:11 Go to previous message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Thanks for the report and patch (see topic http://fudforum.org/forum/index.php?t=msg&goto=159785).
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Attachments in newsgroups aren't decoded
Next Topic: why i cannot add a new Category of Forum
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sat Oct 21 04:37:38 EDT 2017

Total time taken to generate the page: 0.00600 seconds