FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » NNTP - empty message bodies
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
NNTP - empty message bodies [message #161061] Thu, 12 November 2009 14:28 Go to next message
artbatista is currently offline  artbatista   United States
Messages: 7
Registered: November 2009
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
I am getting a lot of imported NNTP messages with "empty message body" as content.

I have logged on to the server and I can see content in these messages with a standard news reader.

Any ideas?

Art
Re: NNTP - empty message bodies [message #161062 is a reply to message #161061] Thu, 12 November 2009 15:01 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3632
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
I've seen it as well. The newly added MIME parser doesn't cope too well with badly formatted MIME posts.
Re: NNTP - empty message bodies [message #161075 is a reply to message #161062] Thu, 12 November 2009 17:17 Go to previous messageGo to next message
artbatista is currently offline  artbatista   United States
Messages: 7
Registered: November 2009
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Anything in the works for this?

Art


naudefj wrote on Thu, 12 November 2009 15:01
I've seen it as well. The newly added MIME parser doesn't cope too well with badly formatted MIME posts.

Re: NNTP - empty message bodies [message #161084 is a reply to message #161075] Fri, 13 November 2009 00:11 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3632
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Maybe later.

Workaround is to back-out this patch: http://fudforum.svn.sourceforge.net/viewvc/fudforum/trunk/install/forum_dat a/include/nntp.inc?r1=4689&r2=4713&sortby=file
Re: NNTP - empty message bodies [message #161092 is a reply to message #161084] Fri, 13 November 2009 16:22 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3632
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Can you please test to see if this will fix it ->

Edit include/nntp.inc, find:

$this->body = $text_body;  // Replace multipart mime by the text body


and replace it with:

if ($text_body) {
	$this->body = $text_body;  // Replace multipart mime by the text body.
}
Re: NNTP - empty message bodies [message #161093 is a reply to message #161092] Fri, 13 November 2009 16:29 Go to previous messageGo to next message
artbatista is currently offline  artbatista   United States
Messages: 7
Registered: November 2009
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
That did it!

So far imported a few hundred messages and I can't find any more empty ones.

Thank you!
Re: NNTP - empty message bodies [message #161095 is a reply to message #161093] Fri, 13 November 2009 16:32 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3632
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Excellent. I'll commit it tomorrow.
Re: NNTP - empty message bodies [message #161096 is a reply to message #161095] Fri, 13 November 2009 16:35 Go to previous messageGo to next message
kerryg is currently offline  kerryg   
Messages: 157
Registered: September 2008
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user
Hmmmm... I have a ton of posts in my forum like that, but unfortunately the NNTP newsgroup that they were sync'd from has gone offline, likely permanently, meaning re-importing them properly isn't an option. Can this be applied to a forum *retroactively* to fix them?
Re: NNTP - empty message bodies [message #161100 is a reply to message #161096] Sat, 14 November 2009 01:50 Go to previous message
naudefj is currently offline  naudefj   South Africa
Messages: 3632
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
It cannot be applied "retroactively" and it is unlikely that you had the same problem. Only badly formatted MIME messages imported with FUDforum 3.x were blanked out.

The problem was introduced with the contributed MIME handler for USENET posts. Pity nobody bothered to test the RC releases well enough to pick it up.
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: SMTP problem
Next Topic: nntp import crashed
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Wed Dec 13 00:37:19 EST 2017

Total time taken to generate the page: 0.00693 seconds