FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » 3.0.1 Queue user's first N posts problem.
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
3.0.1 Queue user's first N posts problem. [message #162447] Wed, 12 May 2010 14:02 Go to next message
XIXs is currently offline  XIXs   United Kingdom
Messages: 11
Registered: July 2004
Location: London
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user

Hiya,

I just tried the 3.0.1 upgrade and I think this part is malfunctioning.

Not exactly sure as it has currently got better, but the original problem was that all posts required admin approval.

Much scratching of heads and random clicking on options, eventually just running the upgrade script again seems to have fixed it.

Currently however, despite being set to 0 it still seems to be forcing the first post from a new user to be approved but at least it isn't every post any more.

Re: 3.0.1 Queue user's first N posts problem. [message #162450 is a reply to message #162447] Wed, 12 May 2010 15:22 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Sounds like a problem we had in the RC release.

Please check if http://sourceforge.net/apps/trac/fudforum/changeset/4942#file3 is on your system.
Re: 3.0.1 Queue user's first N posts problem. [message #162453 is a reply to message #162450] Fri, 14 May 2010 14:25 Go to previous messageGo to next message
XIXs is currently offline  XIXs   United Kingdom
Messages: 11
Registered: July 2004
Location: London
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user

that bit is fine

however just above it is a check for

($usr->posted_msg_count > $MOD_FIRST_N_POSTS || $MOD)) // Min quota posts reached.

Which I'm guessing should be changed to >=

right?
Re: 3.0.1 Queue user's first N posts problem. [message #162455 is a reply to message #162453] Fri, 14 May 2010 16:17 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Ah, that's it! There are 2 conditions. I've only looked at the second.

Have you tested it, is it safe to commit?
Re: 3.0.1 Queue user's first N posts problem. [message #162461 is a reply to message #162455] Fri, 14 May 2010 20:24 Go to previous messageGo to next message
XIXs is currently offline  XIXs   United Kingdom
Messages: 11
Registered: July 2004
Location: London
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user

Yup, I changed that to a >= and could post as a new user without hitting the moderation queue.

So yes, that's a working fix Smile
Re: 3.0.1 Queue user's first N posts problem. [message #162464 is a reply to message #162461] Sat, 15 May 2010 03:18 Go to previous message
naudefj is currently offline  naudefj   South Africa
Messages: 3624
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Thanks! Patch was committed. Details at http://sourceforge.net/apps/trac/fudforum/changeset/4956
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Replacement and Censorship System
Next Topic: New registrations - login name - first letter gets drop
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sat Oct 21 17:18:36 EDT 2017

Total time taken to generate the page: 0.00621 seconds