FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » Images uploaded don't show up in message
Show: Today's Messages :: Unread Messages :: Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
Message by TheDude is ignored  [reveal message]  [reveal all messages by TheDude]  [stop ignoring this user] Go to next message
Re: Images uploaded don't show up in message [message #168920 is a reply to message #168919] Thu, 08 August 2013 14:30 Go to previous messageGo to next message
naudefj is currently offline  naudefj   
Messages: 3771
Registered: December 2004
Karma: 27
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Caused by patch @ http://fudforum.org/forum/index.php?t=msg&goto=167755

I'll prepare a fix.
Re: Images uploaded don't show up in message [message #168925 is a reply to message #168920] Fri, 09 August 2013 10:37 Go to previous messageGo to next message
naudefj is currently offline  naudefj   
Messages: 3771
Registered: December 2004
Karma: 27
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Fixed at http://sourceforge.net/p/fudforum/code/5637/
Message by TheDude is ignored  [reveal message]  [reveal all messages by TheDude]  [stop ignoring this user] Go to previous messageGo to next message
Re: Re : Re: Images uploaded don't show up in message [message #169063 is a reply to message #168929] Mon, 19 August 2013 15:06 Go to previous messageGo to next message
naudefj is currently offline  naudefj   
Messages: 3771
Registered: December 2004
Karma: 27
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
It's in FUDforum 3.0.5RC1 and subsequent releases.
Image file is corrupted on download [message #184861 is a reply to message #168919] Tue, 11 February 2014 15:04 Go to previous messageGo to next message
wferguss   Canada
Messages: 11
Registered: December 2013
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
I'm running FUDforum 3.0.5.

When I attach a txt file to a message and click to download it, everything is fine. If I do the same with an image file (eg. jpg) the download fails. In IE and Chrome it displays a broken image link, in Firefox it shows "The image "http://.../index.php?t=getfile&id=1&" cannot be displayed because it contains errors"

I used wget to download the file and looked at the raw data - 0x0A has been prepended to the beginning of the file (although the file size hasn't changed from the original - the end has been cut off). This 0x0A is not present in the attachment file on disk.

How is this extra data getting tacked on to the image file during download, and how do I make it stop?
Re: Image file is corrupted on download [message #184879 is a reply to message #184861] Thu, 13 February 2014 00:02 Go to previous messageGo to next message
rshannon is currently offline  rshannon
Messages: 18
Registered: August 2002
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Also having this problem. Wondering where the images are stored. In a directory, in the DB?
Re: Re : Re: Images uploaded don't show up in message [message #184881 is a reply to message #169063] Thu, 13 February 2014 00:57 Go to previous messageGo to next message
rshannon is currently offline  rshannon
Messages: 18
Registered: August 2002
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
I am still experiencing this issue in 3.06RC2.
Re: Image file is corrupted on download [message #184888 is a reply to message #184879] Thu, 13 February 2014 10:11 Go to previous messageGo to next message
wferguss   Canada
Messages: 11
Registered: December 2013
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Attachments are stored in the fudforum-data directory (wherever you configured that to be), under "files". If you can query the db, the path to a given attachment file is in the "location" field of the <prefix>_attach table.
Re: Image file is corrupted on download [message #184889 is a reply to message #184888] Thu, 13 February 2014 10:38 Go to previous messageGo to next message
wferguss   Canada
Messages: 11
Registered: December 2013
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Looks like the same 0x0A character gets tacked on for text files and PDF files too, but in those cases it doesn't prevent the file from opening.
Re: Image file is corrupted on download [message #184890 is a reply to message #184889] Thu, 13 February 2014 13:14 Go to previous messageGo to next message
wferguss   Canada
Messages: 11
Registered: December 2013
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Figured it out, at least for my case. There was an extra linefeed at the end of the ckeditor.plugin file, which was being sent to the output buffer before the attachment file. If you're not using this plugin it might be something similar from another source.

I found it using debug statements that printed the length of the output buffer. In getfile.php, the output buffer length was 1 before the readfile command. I kept moving them backwards through the code until I found the point where the extra data was getting inserted, which was when the plugin file was included.
Re: Image file is corrupted on download [message #184893 is a reply to message #184890] Thu, 13 February 2014 15:54 Go to previous messageGo to next message
wferguss   Canada
Messages: 11
Registered: December 2013
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Hm. When I went to propagate the fix to my production instance, I had to apply the fix to a different plugin file (the plugins were listed in a different order in the plugin_cache file - in both cases it was the last one that needed to be fixed). But on my test instance, that file does not have a blank line at the end of it. Not sure how this blank line is getting into random files...

[Updated on: Thu, 13 February 2014 16:01]

Report message to a moderator

Re: Image file is corrupted on download [message #184985 is a reply to message #184893] Sat, 22 February 2014 04:13 Go to previous messageGo to next message
naudefj is currently offline  naudefj   
Messages: 3771
Registered: December 2004
Karma: 27
Senior Member
Administrator
Core Developer
remove from buddy list
ignore all messages by this user
Maybe we should remove all PHP closing ?> tags from all plugin files.
Will update it later today.
Message by xupetas is ignored  [reveal message]  [reveal all messages by xupetas]  [stop ignoring this user] Go to previous messageGo to next message
Message by xupetas is ignored  [reveal message]  [reveal all messages by xupetas]  [stop ignoring this user] Go to previous message
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: flood check reset
Next Topic: Error in confirmation email in Greek Language
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Wed May 18 08:45:18 EDT 2022

Total time taken to generate the page: 0.00729 seconds