FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum » FUDforum Suggestions » double history fix
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
double history fix [message #17499] Wed, 31 March 2004 19:53 Go to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user

users has been complaining about having to press back two times, so I have fixe it (I think so), I changed row 202 in lib.js (1.15) from
window.location.hash = mid_hash;

to
window.location.replace(window.location.href + '#' + mid_hash);
Re: double history fix [message #17500 is a reply to message #17499] Wed, 31 March 2004 22:27 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Does this not cause the problem?

(Will need to try it out).


FUDforum Core Developer
Re: double history fix [message #17501 is a reply to message #17500] Thu, 01 April 2004 04:59 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user

if I put {TEMPLATE-DATA: msg_page_focus} at bottom of the page all works
Re: double history fix [message #17502 is a reply to message #17501] Thu, 01 April 2004 09:57 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
The change you propose does not work in KHTML (Konqueror & Safari) as well as Opera. In Mozilla FireFox it works, BUT the back button issue is still there, so nothing is fixed. I didn't bother trying it in IE due to the above mentioned problems.
Re: double history fix [message #17503 is a reply to message #17502] Thu, 01 April 2004 10:02 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user

Ilia wrote on Thu, 01 April 2004 16:57

The change you propose does not work in KHTML (Konqueror & Safari) as well as Opera. In Mozilla FireFox it works, BUT the back button issue is still there, so nothing is fixed. I didn't bother trying it in IE due to the above mentioned problems.

for us there is no back-issue, did you remove the first line? you can not have both, you must choose one of them. either the new one or the old.

edit: ok, it wont work in those browser, it's because !OPERA in js.

[Updated on: Thu, 01 April 2004 10:05]

Report message to a moderator

Re: double history fix [message #17505 is a reply to message #17503] Thu, 01 April 2004 11:43 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
I've removed the OPERA exclusion code etc... but it still does not work in Opera and Konqueror and does not resolve the back history issue in other browsers.
Re: double history fix [message #17515 is a reply to message #17505] Thu, 01 April 2004 14:47 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user

Ilia wrote on Thu, 01 April 2004 18:43

I've removed the OPERA exclusion code etc... but it still does not work in Opera and Konqueror and does not resolve the back history issue in other browsers.

hmm, strage, perhaps this then:
function fud_msg_focus(mid_hash)
{
        if(OPERA && IE4 && !window.location.hash)
        {
                window.location.href = window.location.href + '#' + mid_hash;
        }
        else if (!window.location.hash) {
                //window.location.hash = mid_hash;
                window.location.replace(window.location.href + '#' + mid_hash);
        }
}
Re: double history fix [message #17516 is a reply to message #17515] Thu, 01 April 2004 14:59 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
The problem is that this does not resolve the duplicate history in Mozilla and still does not with with KHTML.
Re: double history fix [message #17520 is a reply to message #17516] Thu, 01 April 2004 16:38 Go to previous messageGo to next message
AzaToth is currently offline  AzaToth   Sweden
Messages: 125
Registered: October 2003
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user

Ilia wrote on Thu, 01 April 2004 21:59

The problem is that this does not resolve the duplicate history in Mozilla and still does not with with KHTML.

strange, it works in Mozilla Firefox, and it's from Netscape, so it should work
Re: double history fix [message #31973 is a reply to message #17515] Sun, 28 May 2006 23:32 Go to previous message
Anonymous   Australia
Karma:
AzaToth wrote on Thu, 01 April 2004 14:47

Ilia wrote on Thu, 01 April 2004 18:43

I've removed the OPERA exclusion code etc... but it still does not work in Opera and Konqueror and does not resolve the back history issue in other browsers.

hmm, strage, perhaps this then:
function fud_msg_focus(mid_hash)
{
        if(OPERA && IE4 && !window.location.hash)
        {
                window.location.href = window.location.href + '#' + mid_hash;
        }
        else if (!window.location.hash) {
                //window.location.hash = mid_hash;
                window.location.replace(window.location.href + '#' + mid_hash);
        }
}


Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Nightly builds
Next Topic: Custom tags
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Tue Oct 24 02:04:55 EDT 2017

Total time taken to generate the page: 0.00789 seconds