FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Plugins and Code Hacks » CSS patch
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
CSS patch [message #26261] Tue, 12 July 2005 08:38 Go to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member
add to buddy list
ignore all messages by this user

this patch make view better code in [code][/code] tags, it's remove unneeded scrolls, add some space between text and container and use fixed width.
Index: forum.css.tmpl
===================================================================
RCS file: /forum21/install/forum_data/thm/default/tmpl/forum.css.tmpl,v
retrieving revision 1.65
diff -r1.65 forum.css.tmpl
546c546,548
< 	overflow: scroll;
---
> 	overflow: auto;
> 	margin: 5px;
> 	width: 700px;

I think it should be added in CVS, may be without "width: 700px;", what are you think Ilia?
Re: CSS patch [message #26264 is a reply to message #26261] Tue, 12 July 2005 09:33 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
The change for overlflow to auto is a good idea, the margin is not necessary IMO, since the css already has a padding of 5px and hardcoding the size to 700px does not seem necessary.

FUDforum Core Developer
Re: CSS patch [message #26266 is a reply to message #26264] Tue, 12 July 2005 09:41 Go to previous messageGo to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member
add to buddy list
ignore all messages by this user

padding - space between inner text
margin - space between outer text
margin = padding looks better fo me Wink, and fixed width - just for for long line witch stretch the page (in current version horizontal scroll never used)
Re: CSS patch [message #26267 is a reply to message #26266] Tue, 12 July 2005 10:12 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Well, I changed to auto and the scroll does not appear until it is necessary, so the goal is achieved. I see no reason to do inner padding, unless you can provide good reasons showing otherwise.

FUDforum Core Developer
Re: CSS patch [message #26269 is a reply to message #26267] Tue, 12 July 2005 10:43 Go to previous messageGo to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member
add to buddy list
ignore all messages by this user

just look Smile

before:
http://www.ljplus.ru/img2/g/g/ggray/before.jpg

after:
http://www.ljplus.ru/img2/g/g/ggray/after.jpg
Re: CSS patch [message #26270 is a reply to message #26269] Tue, 12 July 2005 10:47 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Not sure what is being shown, but I've changed the overflow to auto in CVS and on my dev forum I no longer get any scroll bars in Firefox, unless there is an actual need for one.

So, I don't see a need to add 700px hard-coded width.


FUDforum Core Developer
Re: CSS patch [message #26271 is a reply to message #26270] Tue, 12 July 2005 10:58 Go to previous messageGo to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member
add to buddy list
ignore all messages by this user

just forget for width Twisted Evil
look for "margin: 5px", it's add 5px transparent space between message text and CODE container (previous screen-shots)
Re: CSS patch [message #26278 is a reply to message #26271] Tue, 12 July 2005 13:57 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Aha I see... Added to CVS.

FUDforum Core Developer
Re: CSS patch [message #26306 is a reply to message #26278] Wed, 13 July 2005 05:18 Go to previous messageGo to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member
add to buddy list
ignore all messages by this user

Gooood Very Happy
Re: CSS patch [message #26471 is a reply to message #26261] Thu, 21 July 2005 23:04 Go to previous messageGo to next message
JamesS is currently offline  JamesS   United States
Messages: 275
Registered: July 2002
Location: Atlanta, GA
Karma: 0
Senior Member
add to buddy list
ignore all messages by this user
Please see this thread for why it was changed to scroll in the first place -- http://fudforum.org/forum/index.php?t=msg&th=4246&
Re: CSS patch [message #26473 is a reply to message #26471] Thu, 21 July 2005 23:12 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
It seems ok now with IE and FF.

FUDforum Core Developer
Re: CSS patch [message #26477 is a reply to message #26261] Fri, 22 July 2005 04:44 Go to previous message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member
add to buddy list
ignore all messages by this user

when overflow option did not set - <div> - resize to content width, otherwise it`s resize to container width.
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Some pointers on thumbnails please
Next Topic: Total users online
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Wed Dec 13 17:49:35 EST 2017

Total time taken to generate the page: 0.00839 seconds