FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » 2.7.6 - Locked Thread Displays Action Buttons for Original Poster and Moderators (Usability Issue: Locked Topics should hide Edit, Reply & Quote buttons for all users.)
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
2.7.6 - Locked Thread Displays Action Buttons for Original Poster and Moderators [message #35675] Tue, 30 January 2007 17:21 Go to next message
Bubba is currently offline  Bubba   United States
Messages: 5
Registered: December 2006
Karma: 0
Junior Member
add to buddy list
ignore all messages by this user
Classification: Usability / UI

Disclaimer: Not sure if application was designed this way for extensibility or an oversight. Code owner should evaluate all possible group & user permission combinations before accepting change.

Description: When moderator locks a thread, all action buttons (edit, reply, quote, etc) should be disabled/hidden for all users.

Issue: Locked threads display "Edit" to original poster and "Edit", "Reply" and "Quote" for Moderators/Admins. Clicking on any results in error page.

Expected: All actionable items are hidden for all users.

File: src/drawmsg.inc.t

Code:
if (_uid && ($perms & 16 || (_uid == $obj->poster_id && (!$GLOBALS['EDIT_TIME_LIMIT'] || __request_timestamp__ - $obj->post_stamp < $GLOBALS['EDIT_TIME_LIMIT'] * 60)))) {
$edit_link = '{TEMPLATE: dmsg_edit_link}';
} else {
$edit_link = '';
}

if (!($obj->thread_opt & 1) || $perms & 4096) {
$reply_link = '{TEMPLATE: dmsg_reply_link}';
$quote_link = '{TEMPLATE: dmsg_quote_link}';
} else {
/* thread is locked, hide reply and quote controls */
$reply_link = $quote_link = '';
}


Possible Fix:
if (_uid && !($obj->thread_opt & 1) && ($perms & 16 || (_uid == $obj->poster_id && (!$GLOBALS['EDIT_TIME_LIMIT'] || __request_timestamp__ - $obj->post_stamp < $GLOBALS['EDIT_TIME_LIMIT'] * 60)))) {
$edit_link = '{TEMPLATE: dmsg_edit_link}';
} else {
$edit_link = '';
}

if (!($obj->thread_opt & 1)) {
$reply_link = '{TEMPLATE: dmsg_reply_link}';
$quote_link = '{TEMPLATE: dmsg_quote_link}';
} else {
/* thread is locked, hide reply and quote controls */
$reply_link = $quote_link = '';
}
Re: 2.7.6 - Locked Thread Displays Action Buttons for Original Poster and Moderators [message #35687 is a reply to message #35675] Wed, 31 January 2007 18:30 Go to previous message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
The display of buttons at all times is actually intentional.

FUDforum Core Developer
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: 2.7.6 - Tread Rating Enables Javascript for Non-Moderators.
Next Topic: Geolocation upload failure
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sat Oct 21 21:07:25 EDT 2017

Total time taken to generate the page: 0.00581 seconds