FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » Broken link in new topic notification mails
Show: Today's Messages :: Unread Messages :: Show Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
Broken link in new topic notification mails [message #38854] Sun, 02 September 2007 03:24 Go to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3631
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
The text part of new topic notification mails contains an invalid link:

"To participate in the discussion, go here:
...?t=rview&th=37

Looking at the HTML part it is clear that the 37 is actually the frm_id and not the thread id.
Re: Broken link in new topic notification mails [message #38855 is a reply to message #38854] Sun, 02 September 2007 03:47 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3631
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Problem is in ./install/forum_data/src/imsg_edt.inc.t - line 786:

$body_email =   $boundry . "Content-Type: text/plain; charset=" . $CHARSET . "; format=flowed\r\nContent-Transfer-Encoding: 7bit\r\n\r\n" . html_entity_decode(strip_tags($plain_text)) . "\r\n\r\n" . html_entity_decode('{TEMPLATE: iemail_participate}') . ' ' . '{FULL_ROOT}{ROOT}?t=rview&th=' . $id . "\r\n" .


Link should be changed to

?t=rview&goto='.$msg_id.'#msg_'.$msg_id

Re: Broken link in new topic notification mails [message #38860 is a reply to message #38854] Sun, 02 September 2007 23:00 Go to previous messageGo to next message
Ilia is currently offline  Ilia   
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
The code is correct, the id being passed should be the topic id, when a notification about a new message is sent.

FUDforum Core Developer
Re: Broken link in new topic notification mails [message #38862 is a reply to message #38860] Mon, 03 September 2007 01:12 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3631
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
$id can be the forum if ($id_type == 'frm').

Can you please look at this again?
Re: Broken link in new topic notification mails [message #38869 is a reply to message #38862] Mon, 03 September 2007 11:37 Go to previous messageGo to next message
Ilia is currently offline  Ilia   
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
In which case the logic is valid, as the link is supposed to direct you to the forum where the new topic was found.

FUDforum Core Developer
Re: Broken link in new topic notification mails [message #38870 is a reply to message #38869] Mon, 03 September 2007 12:59 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3631
Registered: December 2004
Karma: 17
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
I cannot see how ...?t=rview&th=37 (where 37 is the forum ID) is going to do that.

Should it maybe be: ...?t=rview&frm_id=37 ???

However, I still prefer linking to the thread (just in case it was moved to a different forum): ...?t=rview&goto='.$msg_id.'#msg_'.$msg_id
Re: Broken link in new topic notification mails [message #38887 is a reply to message #38870] Tue, 04 September 2007 19:45 Go to previous message
Ilia is currently offline  Ilia   
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
You are right, the fix is in the CVS

FUDforum Core Developer
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Report message to a moderator
Next Topic: E-mail addresses with underscore characters
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Mon Dec 11 14:18:34 EST 2017

Total time taken to generate the page: 0.00807 seconds