FUDforum: PHP discussions » Script problem

Home » General » PHP discussions » Script problem (Scritpt doesn't update database in email validation)

Show: Today's Messages :: Polls :: Message Navigator

Re: Script problem [message #165240 is a reply to message #165239]

Sun, 15 May 2011 16:50

naudefj

Messages: 3771
Registered: December 2004

Karma:

Senior Member
Administrator
Core Developer

Not bad, but you need to pay attention to the following:

1. Proper code indentation - your code is difficult to read.
2. Use consistent white space around concatenations - this look like a cut and paste job.
2. Use singe quotes where possible and appropriate - you switch between singe and double quotes without apparent reason.
4. Why append an empty string in: echo "Congratulations!" . $row["login"] . "";?
5. Don't store 'activated' in the DB (too long). Shorten it to STATUS='A' or even better, an a bit value of an integer.
6. You may want to close the DB connection when you are done.

Best of luck!

Report message to a moderator

[Message index]

		Script problem By: anemic-cinema on Fri, 13 May 2011 12:40
		Re: Script problem By: naudefj on Sat, 14 May 2011 12:43
		Re: Script problem By: anemic-cinema on Sat, 14 May 2011 13:07
		Re: Script problem By: naudefj on Sun, 15 May 2011 16:50
		Re: Script problem By: anemic-cinema on Sun, 15 May 2011 20:23
		Re: Script problem By: Ernesto on Tue, 17 May 2011 03:01
		Re: Script problem By: anemic-cinema on Tue, 17 May 2011 16:26

Previous Topic:	Usenet group import
Next Topic:	Choose PHP Framework Tips

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sun May 12 11:25:55 GMT 2024

Total time taken to generate the page: 0.04386 seconds