FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Plugins and Code Hacks » Proposed code change for potentially more unique sysid
Show: Today's Messages :: Polls :: Message Navigator
Return to the default flat view Create a new topic Submit Reply
Proposed code change for potentially more unique sysid [message #184644] Tue, 14 January 2014 15:08 Go to previous message
kmoradha is currently offline  kmoradha
Messages: 8
Registered: January 2014
Karma:
Junior Member
Hi, this is my first proposed change, so please let me know if I'm not following the right procedure (I've read the SVN docs on the wiki site).

We were experiencing session collisions for new logins, as the ses_make_sysid() function was not generating unique enough identifiers. We are using basic authentication on our server, so I'm proposing to add REMOTE_USER to the set of environment variables used to uniquely identify the client browser. For installs where basic authentication is not used, this addition will have no impact.

Below is the change...please review and let me know if I can apply for commit access in SourceForge.

--- cookies.inc.t-orig  2014-01-14 09:57:48.986943684 -0500
+++ cookies.inc.t       2014-01-14 09:58:06.153061812 -0500
@@ -15,7 +15,7 @@
                return;
        }

-       $keys = array('HTTP_USER_AGENT', 'SERVER_PROTOCOL', 'HTTP_ACCEPT_CHARSET', 'HTTP_ACCEPT_LANGUAGE');
+       $keys = array('REMOTE_USER', 'HTTP_USER_AGENT', 'SERVER_PROTOCOL', 'HTTP_ACCEPT_CHARSET', 'HTTP_ACCEPT_LANGUAGE');
        if ($GLOBALS['FUD_OPT_3'] & 16) {       // SESSION_IP_CHECK
                $keys[] = 'HTTP_X_FORWARDED_FOR';
                $keys[] = 'REMOTE_ADDR';
[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Add a desktop instant messenger to your FUDforum forum
Next Topic: Proposed code change to add AUTO_LOGIN plugin hook
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Thu Mar 28 14:02:10 GMT 2024

Total time taken to generate the page: 0.04826 seconds