FUDforum: Bug Reports » php-error-log undefined lang on line 33

Home » FUDforum Development » Bug Reports » php-error-log undefined lang on line 33 (theme_router.plugin 1.0)

Show: Today's Messages :: Polls :: Message Navigator

php-error-log undefined lang on line 33 [message #165895]

Sat, 20 August 2011 16:53

Atomicrun

Messages: 54
Registered: November 2010
Location: Lund

Karma: 0

Member

It go like this, function plugin_theme_router( $usr) the first function, use a variable $lang

if ( isset( $_SERVER[ 'HTTP_ACCEPT_LANGUAGE'])) 
{
   $lang  = substr( $_SERVER[ 'HTTP_ACCEPT_LANGUAGE'], 0, 2);
}
if ( isset( $themes[ $lang])) 
{
   $theme = $themes[ $lang];
}

The result is OK; when $lang is undefined isset( $themes[ $lang]) is still false, but the undefined $lang put an error-line in the php-error-log.

if ( isset( $_SERVER[ 'HTTP_ACCEPT_LANGUAGE'])) 
{
   $lang  = substr( $_SERVER[ 'HTTP_ACCEPT_LANGUAGE'], 0, 2);
   if ( isset( $themes[ $lang])) 
   {
      $theme = $themes[ $lang];
   }
}

The $theme have an OK default value, so a modification occur only if all is OK.

Report message to a moderator