|
|
Re: FUDforum and valid HTML [message #33568 is a reply to message #33527] |
Thu, 07 September 2006 18:42 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
Further validator results:
- login page:
a </span> has to be replaced by </font>
- Today's messages, Unanswered messages (for anon users):
<th align=middle> has to use "LEFT", "CENTER", "RIGHT", "JUSTIFY" or "CHAR" for the attribute align
- Help files:"&" should be encoded to &
- error messages (e.g. ERROR: ...): many problems (I didn't figure out the details)
[Updated on: Fri, 08 September 2006 14:54] Report message to a moderator
|
|
|
|
|
|
|
Re: FUDforum and valid HTML [message #33611 is a reply to message #33527] |
Sun, 10 September 2006 16:22 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
I have seen that there are multiple HTML problems within the Admin Control Panel. I can make patch so it nearly meets the standard. But as this implies a quite large number of changes I think you want to address this in the next version (2.7.7)?
[Updated on: Sun, 10 September 2006 17:01] Report message to a moderator
|
|
|
|
|
|
|
|
|
|
|
Re: FUDforum and valid HTML [message #35331 is a reply to message #33527] |
Fri, 29 December 2006 16:18 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
I have attached a patch with suggestions for making the Admin Control Panel more w3c compliant.
Sorry that it took so long, but is was not as easy as I thought. I have found some problems in the Admin Control Panel that I can't fix because of limited knowledge...
I have nearly changed all files in adm folder, I couldn't check admspell.php because the option is not available in my installation.
My changes:
- I have tried to do some kind of hack to make the phpinfo page looking better. In order to achieve this I have removed the style information from phpinfo and put some of it in adm.css. This is not optimal solution I think, it also makes all images in Admin Control Panel to be right aligned. Maybe you have a better idea?
- I added alt descriptions to images because validator wants to have them.
- Where new white pages are displayed in some situations I added code so that the output is valid html, which makes the code look more complex. I also added page title and doctype to the Control Panel.
- Validator wanted that <table></table> is within <form></form>. The according changes led to a noticable layout change in admuser.php, which I couldn't fix.
Some things that attracted my attention, but I couldn't fix:
- On some pages errors are display simply be executing echo 'error message'. This makes the whole page being invalid html. I couldn't find out how to make better output of error messages.
- tmpllist.php produces a strange sorting sometimes. When I expand a template it is put at the beginning of the list, so far it is OK. However, when I expand more templates suddenly all expanded templates are put to the end of the list. Why this?
- In admnntp.php there is a empty <select></select> in case there are no forums that can be used for the mailing list. I would suggest to give out a error message here instead.
- There is a MySQL query error in case I want to add a avatar without a description:
(C:\xampp\htdocs\FUDforum\include\theme\default\db.inc:72
C:\xampp\htdocs\forum\adm\admavatar.php:129
) 1048: Column 'descr' cannot be null
Query: INSERT INTO fud26_avatar (img, descr, gallery) VALUES ('water.jpg', NULL, 'default')
_POST: array ( 'S' => 'a95ffac3efb349f502d4d79ec39979c5', 'SQ' => '7dee05e7f1bf24209729cc6907545c8d', 'gallery_path' => '', 'tmp_f_val' => '1', 'avt_descr' => '', 'avt_gal_m' => '', 'avt_img' => 'water.jpg', 'btn_submit' => 'Add Avatar', 'edit' => '', )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/adm/admavatar.php
-
Attachment: acp.zip
(Size: 22.06KB, Downloaded 1069 times)
|
|
|
|
|
|
|
|
Re: FUDforum and valid HTML [message #35431 is a reply to message #33527] |
Wed, 10 January 2007 21:14 |
JanRei
Messages: 361 Registered: October 2005 Location: Germany
Karma: 0
|
Senior Member Contributing Core Developer Translator |
|
|
I agree that it doesn't add functionality, but I think it makes a better impression to users of the FUDforum if it produces more or less valid HTML.
As far for 3) you have tried to fix the same issue on another page with commit 11708. But I think this doesn't look very good, because you now always have a empty option. I also think admmlist.php and admnntp.php should behave the same.
Oh, and I found a mistake in my patch, I have a attached a patch that fixes this.
[Updated on: Wed, 10 January 2007 21:14] Report message to a moderator
|
|
|
Re: FUDforum and valid HTML [message #35442 is a reply to message #35431] |
Fri, 12 January 2007 02:14 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
The patch was added thanks. I've also added the dummy option to the mailing list control panel.
FUDforum Core Developer
|
|
|