FUDforum: Bug Reports » Broken link in new topic notification mails

Home » FUDforum Development » Bug Reports » Broken link in new topic notification mails

Show: Today's Messages :: Polls :: Message Navigator

Broken link in new topic notification mails [message #38854]

Sun, 02 September 2007 07:24

naudefj

Messages: 3772
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

The text part of new topic notification mails contains an invalid link:

"To participate in the discussion, go here:
...?t=rview&th=37

Looking at the HTML part it is clear that the 37 is actually the frm_id and not the thread id.

Report message to a moderator

Re: Broken link in new topic notification mails [message #38855 is a reply to message #38854]

Sun, 02 September 2007 07:47

naudefj

Messages: 3772
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Problem is in ./install/forum_data/src/imsg_edt.inc.t - line 786:

$body_email =   $boundry . "Content-Type: text/plain; charset=" . $CHARSET . "; format=flowed\r\nContent-Transfer-Encoding: 7bit\r\n\r\n" . html_entity_decode(strip_tags($plain_text)) . "\r\n\r\n" . html_entity_decode('{TEMPLATE: iemail_participate}') . ' ' . '{FULL_ROOT}{ROOT}?t=rview&th=' . $id . "\r\n" .

Link should be changed to

?t=rview&goto='.$msg_id.'#msg_'.$msg_id

Report message to a moderator

Re: Broken link in new topic notification mails [message #38860 is a reply to message #38854]

Mon, 03 September 2007 03:00

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

The code is correct, the id being passed should be the topic id, when a notification about a new message is sent.

FUDforum Core Developer

Report message to a moderator

Re: Broken link in new topic notification mails [message #38862 is a reply to message #38860]

Mon, 03 September 2007 05:12

naudefj

Messages: 3772
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

$id can be the forum if ($id_type == 'frm').

Can you please look at this again?

Report message to a moderator

Re: Broken link in new topic notification mails [message #38869 is a reply to message #38862]

Mon, 03 September 2007 15:37

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

In which case the logic is valid, as the link is supposed to direct you to the forum where the new topic was found.

FUDforum Core Developer

Report message to a moderator

Re: Broken link in new topic notification mails [message #38870 is a reply to message #38869]

Mon, 03 September 2007 16:59

naudefj

Messages: 3772
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

I cannot see how ...?t=rview&th=37 (where 37 is the forum ID) is going to do that.

Should it maybe be: ...?t=rview&frm_id=37 ???

However, I still prefer linking to the thread (just in case it was moved to a different forum): ...?t=rview&goto='.$msg_id.'#msg_'.$msg_id

Report message to a moderator

Re: Broken link in new topic notification mails [message #38887 is a reply to message #38870]

Tue, 04 September 2007 23:45

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

You are right, the fix is in the CVS

FUDforum Core Developer

Report message to a moderator

Previous Topic:	Report message to a moderator
Next Topic:	E-mail addresses with underscore characters

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon Dec 30 16:19:02 GMT 2024

Total time taken to generate the page: 1.43771 seconds