FUDforum: Bug Reports » [2.5.0stable]bug in msglist.php

Home » FUDforum Development » Bug Reports » [2.5.0stable]bug in msglist.php

Show: Today's Messages :: Polls :: Message Navigator

[2.5.0stable]bug in msglist.php [message #11404]

Fri, 27 June 2003 04:13

gladiator

Messages: 61
Registered: June 2002
Location: Beijing

Karma: 0

Member

I use apache1.3.27+php4.3.2 on a linux box.
just installed 2.5.0 stable, found that I can't change text messages while using any one of "Edit Text Messages" link in "Template Editor" function.

after examin the file msglist.php, I found that each string value in $msglist_arr[] is prefixed by a whitespace, which should not be there.

so I added a line "$v = trim($v);" right after line 94("foreach ($msglist_arr as $v) {"), then everything works fine.

Is there anyone encounted this bug too?

Report message to a moderator

Re: [2.5.0stable]bug in msglist.php [message #11446 is a reply to message #11404]

Sun, 29 June 2003 17:40

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

The white space is intentional and should remain as is.

FUDforum Core Developer

Report message to a moderator

Re: [2.5.0stable]bug in msglist.php [message #11460 is a reply to message #11446] Mon, 30 June 2003 06:09

gladiator

Messages: 61
Registered: June 2002
Location: Beijing

Karma: 0

Member

prottoss wrote on Mon, 30 June 2003 01:40

The white space is intentional and should remain as is.

I fully understand the white space is intentional in the array msglist_arr, but when it comes to the line


<?php
if (($s = strpos($data, $v . ':')) === FALSE)
?>

the 'if' condition here will always return FALSE if string in $v still contain a prefixed white space.....and, the msg file won't change after we click the button "Edit".

[Updated on: Thu, 31 July 2003 18:58]

Report message to a moderator

Re: [2.5.0stable]bug in msglist.php [message #11467 is a reply to message #11446] Mon, 30 June 2003 08:35

gladiator

Messages: 61
Registered: June 2002
Location: Beijing

Karma: 0

Member

found another bug in msglist.php:
I noticed last change of msglist.php in cvs is changed line 95 from


<?php
if (($s = strpos($data, $v)) === FALSE) {
?>


<?php
if (($s = strpos($data, $v . ':')) === FALSE) {
?>

,

I found that this change should apply to the line 191 too.

[Updated on: Mon, 30 June 2003 08:36]

Report message to a moderator

Previous Topic:	Can't post
Next Topic:	Little Bug

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Nov 22 23:22:21 GMT 2024

Total time taken to generate the page: 0.02770 seconds