FUDforum: Bug Reports » Minor: announcements placement

Home » FUDforum Development » Bug Reports » Minor: announcements placement

Show: Today's Messages :: Polls :: Message Navigator

Minor: announcements placement [message #11899]

Tue, 22 July 2003 11:20

ctbk

Messages: 142
Registered: April 2002
Location: Milan, Italy

Karma: 0

Senior Member

Not really a bug, in fact.
In 2.5.0, announcements are under the topics table's headers, and not over it, like in the previous versions.

From the fact the announcements template is a row and not a whole table, I suspect this behaviour is intentional.

Anyway, a change in the thread & threadt templates solves this aesthetic issue. Smile

~
~
:wq

Report message to a moderator

Re: Minor: announcements placement [message #11900 is a reply to message #11899]

Tue, 22 July 2003 11:35

ctbk

Messages: 142
Registered: April 2002
Location: Milan, Italy

Karma: 0

Senior Member

Anyway, I think colspans in Announcements & Moved Topic entries are wrong.

in thread_view_common.inc.t, line 73:

$ann_cols = ($ENABLE_THREAD_RATING == 'Y' ? 9 : 8) + $MOD;

should be

$ann_cols = ($ENABLE_THREAD_RATING == 'Y' ? 8 : 7) + $MOD;

and in thread.tmpl, line 175:

<td class="RowStyleB" colspan=10 align="center" class="GenText">{MSG: was_moved_msg}</td>

should depend upon a variable, but it doesn't. If you have thread rating enabled this line should become:

<td class="RowStyleB" colspan=7 align="center" class="GenText">{MSG: was_moved_msg}</td>

else:

<td class="RowStyleB" colspan=8 align="center" class="GenText">{MSG: was_moved_msg}</td>

But in this way the extra TD you have in the table when you are a moderator/administrator is not considered in the moved topic row.

~
~
:wq

[Updated on: Tue, 22 July 2003 12:18]

Report message to a moderator

Re: Minor: announcements placement [message #11936 is a reply to message #11900]

Wed, 23 July 2003 01:41

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Fixed in CVS, thanks for letting me know about the problem.

FUDforum Core Developer

Report message to a moderator

Previous Topic:	Back button
Next Topic:	Group Leaders Bugs

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Nov 22 18:36:49 GMT 2024

Total time taken to generate the page: 0.02756 seconds