| various validation and cosmetic issues [message #158830] |
Wed, 01 April 2009 20:20  |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
|
|
I have noticed some validation issues (particular within user control panel, help and post form) and tried to fix them. While being at it I also made some cosmetic changes. You will find a detailed list of suggested changes below and the corresponding patches in the attached archive. Hopefully they are good enough to be included into FUDforum.
There are some things I could not fix. For example, lists ([LIST][*]item[/LIST]) do not seem to be transformed into valid XHTML. Among other things, the W3C validator expects <li> tags to be closed by </li>. Unfortunately I didn't understand fully how these lists are parsed.
drawmsg.diff
- fix some validation issues related to the display of attachments and polls
msg.diff
- small validation fixes
- remove dot from option name (consistency)
- small cosmetic change related to the display of the number of currently attached files
post_common.diff
- fix validation issues related to attachments
- separate max number of files and number of currently attached files by a semicolon
- change Kb to KB (consistency)
ps_cache, sp_cache
- HTML -> XHTML
post_proc.diff
- attempt to fix validation issues related to spoilers
ppost.diff
- show "Private Messaging ยป Writing a Private Message" below the tab row (more consistent in my opinion)
register.diff
- remove a javascript related to the ICQ notifications (not supported anymore as far as I know) which also fixes validation
uc.diff:
- fix validation issues on "Notifications" tab in user control panel
usermaintance.diff, boardusage.diff, readingposting.diff
- some validation fixes
- separate help topics consistently by one empty line
- some changes in help texts to improve consistency a bit
[Updated on: Wed, 01 April 2009 20:23] Report message to a moderator |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: various validation and cosmetic issues [message #161027 is a reply to message #158830] |
Tue, 10 November 2009 23:39  |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
|
|
Do you think that the mentioned change concerning __adm_rsid in install/forum_data/include/adm.inc can be reverted now? Like I said it would fix some validation issues. I hope the problems with the pop-ups has been fixed with my previous patches.
On this occasion I would like to mention some smaller problems I have noticed in the meantime:
1) It seems that the English theme misses an default value for text direction. During theme compilation the following warning appears:
Quote:Warning: file_get_contents(E:/xampp/htdocs/FUDforum/thm/default/i18n/english/dir) [<a href='function.file-get-contents'>function.file-get-contents</a>]: failed to open stream: No such file or directory in E:\xampp\htdocs\FUDforum\include\compiler.inc on line 682
2) I think create_file_list should be adjusted to keep SVN information out of the installer archive:
Index: create_file_list
===================================================================
--- create_file_list (revision 4862)
+++ create_file_list (working copy)
@@ -28,7 +28,7 @@
}
while (($f = readdir($d))) {
- if ($f == '.' || $f == '..' || $f == 'CVS') continue;
+ if ($f == '.' || $f == '..' || $f == '.svn') continue;
if (is_file($v . "/" . $f)) {
$fdata = file_get_contents($v . "/" . $f);[Updated on: Tue, 10 November 2009 23:40] Report message to a moderator |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]