FUDforum: Plugins and Code Hacks » Database host:port support

Home » FUDforum Development » Plugins and Code Hacks » Database host:port support

Show: Today's Messages :: Polls :: Message Navigator

Database host:port support [message #163964]

Fri, 17 December 2010 12:57

mguillaume

Messages: 13
Registered: December 2010

Karma: 0

Junior Member

Right now we don't have support for non-standard db ports (at least in PostgreSQL) though the GLOBALS_HELP suggest we should be able to use the "host:port" notation for the db host.

Suggestion: in data/sql/pgsql/db.inc, replace:

if ($GLOBALS['DBHOST']) {
    $connect_str .= 'host='. $GLOBALS['DBHOST'];
}

with:

if ($GLOBALS['DBHOST']) {
    $hostport=explode(":",$GLOBALS['DBHOST']);
    if (count($hostport)==1) {
        $connect_str .= 'host='. $GLOBALS['DBHOST'];
    } else {
        $connect_str .= 'host='.$hostport[0].' port='.$hostport[1];
    }
}

Note that this probably should be improved upon to support IPv6 addresses (which include ':' in their notation).

Report message to a moderator

Re: Database host:port support [message #163965 is a reply to message #163964]

Sat, 18 December 2010 23:19

naudefj

Messages: 3775
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Can you please test the below code (with IPv6 support)?

if ($GLOBALS['DBHOST']) {
        // Expand optional port number (e.g. [::1]:5432).
        if ( preg_match('/^(.+):(\d*)$/', $GLOBALS['DBHOST'], $m)) {
                $GLOBALS['DBHOST'] = $m[1] .' port='. $m[2];
        }
        // Remove IPv6 block quotes.
        $connect_str .= preg_replace('/\[|\]/', '', 'host='. $GLOBALS['DBHOST']);
}

Report message to a moderator