FUDforum: FUDforum 3.0+ » Get rid of __autoload() and global settings

Home » FUDforum Development » FUDforum 3.0+ » Get rid of __autoload() and global settings (Lazy practice, messes up other frameworks' code)

Show: Today's Messages :: Polls :: Message Navigator

Get rid of __autoload() and global settings [message #166598]

Fri, 27 January 2012 14:52

NeXuS
Messages: 121
Registered: July 2010
Location: South Korea

Karma: 5

Senior Member
Contributing Core Developer

Hi,
in my infinite struggle to have FUDforum and CodeIgniter get along well, I came across an instance where the presence of __autoload() in core.inc causes problems (it tries to load one of CI's classes, which obviously is not in FUD's path).

I had to resort to a ugly hack checking the classname, but it would just be much better to get rid of __autoload in the first place and include the necessary files when needed (I will have to redo the hack every time I update FUD).

Also the use of tons of globals may lead to name conflicts. It would be much better to have only one global variable which is an object of options (or array of options).

Report message to a moderator

Re: Get rid of __autoload() and global settings [message #166610 is a reply to message #166598]

Sat, 28 January 2012 04:27

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

The autoloader was fixed to only look of and load exiting FUDforum libraries.
Details @ http://fudforum.svn.sourceforge.net/viewvc/fudforum/trunk/install/forum_dat a/include/core.inc?r1=5376&r2=5388

Report message to a moderator

Re: Get rid of __autoload() and global settings [message #166612 is a reply to message #166610]

Sat, 28 January 2012 05:14

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Changing all settings to one global variable will be a lot of work. You are welcome to implement it, provided you do all the work yourself and leave the code in a working state. Let me know if you need SVN commit access.

Report message to a moderator

Re: Get rid of __autoload() and global settings [message #166613 is a reply to message #166612]

Sat, 28 January 2012 13:34

NeXuS
Messages: 121
Registered: July 2010
Location: South Korea

Karma: 5

Senior Member
Contributing Core Developer

I'll first work on a local tree, if I can get everything in order I will then ask for SVN access.

Thanks

Report message to a moderator

Previous Topic:	3.0.4 and php
Next Topic:	Props to Frank

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Nov 21 17:22:18 GMT 2024

Total time taken to generate the page: 0.02685 seconds