FUDforum: Bug Reports » A bunch of patches

Home » FUDforum Development » Bug Reports » A bunch of patches

Show: Today's Messages :: Polls :: Message Navigator

A bunch of patches [message #166881]

Sat, 17 March 2012 14:56

macrule

Messages: 2
Registered: March 2012

Karma: 0

Junior Member

I have recently done a FUDforum installation (awesome software!) and in the process found and fixed a couple of issues. I have them currently in a local git repository based on the SVN trunk. Since I don't know how the developers here work, I was wondering about the best way to submit them?

If there are no objections I would do a "git format-patch" and attach the packet here. This would give one patch-file per commit, including my commit message. Those patch are not patch(1) compatible I fear, but they could be applied to any source tree with "git apply" (no need for it to be a git-repo, you just need to have git installed).

Report message to a moderator

Re: A bunch of patches [message #166882 is a reply to message #166881]

Sun, 18 March 2012 03:35

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Hi Macrule,

Unfortunately we're still on SVN. Anyway, the first step would be to upload your patches here, preferably in unidiff, but if you cannot, in any other readable format. If the patches are of high quality, we will apply them or alternatively arrange you SVN access (if you want to do it yourself).

We can also discuss a future GIT migration. However, the current priority is just to get FUDforum 3.0.4RC1 out.

Best regards.
Frank

Report message to a moderator

Aw: Re: A bunch of patches [message #166883 is a reply to message #166882]

Sun, 18 March 2012 07:59

macrule

Messages: 2
Registered: March 2012

Karma: 0

Junior Member

Hi Frank,

I didn't mean to push for a git move Smile

- I just came to find it very handy, especially as a local frontend to SVN repositories.

I haven't really worked with git-generated diff's with patch(1) before, but in a short test they seem to work with "patch -p1 < patchfile". So I have just attached them as they are, and hope they work for you.

If there are questions about the why and how of some changes, feel free to ask.

Best regards,
Bernd

Attachment: patches.tar.bz2
(Size: 10.50KB, Downloaded 744 times)

Report message to a moderator

Re: Aw: Re: A bunch of patches [message #167052 is a reply to message #166883]

Wed, 18 April 2012 12:55

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

List of patches (I will update this message as I work through them):

0001-Fixed-bad-destination-URL-after-submitting-a-poll-in.patch
Unable to reproduce problem - voting works 100% with PATH_INFO.

0002-For-themes-marked-with-a-.path_info-file-make-the-co.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5487&view=rev

0003-Fixed-warnings-about-missing-tables-during-installat.patch
To be reviewed. "IF EXISTS" syntax doesn't work with all the databases we support.

0004-Fix-Savepoints-were-not-released-which-can-cause-iss.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5447&view=rev
Note: Same patch was applied to pdo_pgsql/db.inc. Hope it's OK!

0005-Fix-prepared-statements-need-to-be-deallocated-even-.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5449&view=rev
We may need something similar for pdo_pgsql/db.inc???

0006-Fix-Savepoints-were-not-released-which-can-cause-iss.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5486&view=rev
We may need something similar for pdo_pgsql/db.inc???

0007-Fix-uppercase-attachment-file-extensions-cause-mime-.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5448&view=rev

0008-Fix-Using-HTTP_ACCEPT_ENCODING-as-part-of-the-sysid-.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5450&view=rev

0009-Fix-Using-FUDforum-behind-a-HTTP-cache-can-cause-the.patch
To be reviewed.

0010-Fix-When-previewing-a-message-on-the-post-page-the-f.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5485&view=rev

0011-Fix-threadt.php.t-used-unbuffered-queries-which-caus.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5451&view=rev

0012-Changed-queries-to-make-file_id-length-foff-availabl.patch
Committed at http://fudforum.svn.sourceforge.net/fudforum/?rev=5488&view=rev

0013-Fix-Not-all-used-tables-were-locked-from-the-start-w.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5452&view=rev

0014-Added-command-line-mode-to-admgeoip.php.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5453&view=rev

0015-Added-automtic-sequence-resetting-for-PostgreSQL-to-.patch
Rather use reset_fud_sequences() in dbadmin.inc.
Besides PostgreSQL, we also need to be able to fix sequences for DB2, Firebird and Oracle.

0016-Changed-BBCode-to-use-span-s-with-style-attribute-fo.patch
To be evaluated.

0017-Added-a-strike-BBCode-tag-for-strikethrough.patch
We already have a similar [del] and [s] ~~tags~~. Do we need to add [strike] as well?

Maybe not (see http://xahlee.org/js/html_s_strike_del_html5.html): The <strike> is not supported in HTML5. The difference between "s" and "del" is that "del" carries a semantic meaning of deleted text. Both are rendered the same.

Converter was updated to change all [strike] to [del] tags.

0018-Fix-during-conversion-of-BBCode-lists-to-HTML-br-tag.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5484&view=rev

0019-Fix-insert-uploaded-image-javascript-link-didn-t-wor.patch
Unable to reproduce.

0020-Fix-jQuery-selected-not-only-the-read-unread-img-if-.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5482&view=rev

0021-Fix-javascript-to-toggle-checkboxes-was-wrong-and-di.patch
Committed @ http://fudforum.svn.sourceforge.net/fudforum/?rev=5481&view=rev

0022-Changed-xmlagg.php-to-retain-HTML-if-the-feed-is-con.patch
To be reviewed.

Report message to a moderator

Previous Topic:	Cannot reload 3.0.3 RC1 backup
Next Topic:	Category Manager

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Dec 03 18:36:09 GMT 2024

Total time taken to generate the page: 0.02297 seconds