FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.
Home » FUDforum Development » Plugins and Code Hacks » Newbie question: where to check in bug fix on sourceforge?
Show: Today's Messages :: Polls :: Message Navigator
Switch to threaded view of this topic Create a new topic Submit Reply
Newbie question: where to check in bug fix on sourceforge? [message #167709] Tue, 04 September 2012 23:25 Go to next message
DPhan is currently offline  DPhan   United States
Messages: 9
Registered: September 2012
Location: San Jose, Calif
Karma: 0
Junior Member
I've found a SQL related problem in the function fud_add_user() in scripts/fudapi.inc.php

I've fixed the problem and would like to check in the code to SourceForge. However in browsing the repository there, I did not see the usual directories that can be seen after the install, such as scripts, plugins, sql, src, etc.

Can someone tell me the procedure to do code check in? I look for a sticky announcement but didn't see one.

Dan

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167711 is a reply to message #167709] Wed, 05 September 2012 05:36 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
See trunk/install/forum_data/scripts/fudapi.inc.php

Procedure to check in code is at SVN.

However, before we give you access, can you please post the patch here for verrification?

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167717 is a reply to message #167711] Wed, 05 September 2012 17:49 Go to previous messageGo to next message
DPhan is currently offline  DPhan   United States
Messages: 9
Registered: September 2012
Location: San Jose, Calif
Karma: 0
Junior Member
The problem was the lack the quote characters for the registration_ip in the SQL insert statement in the function fud_add_user()

diff -u fudapi.inc.php-orig fudapi.inc.php

--- fudapi.inc.php-orig 2012-09-05 10:44:14.000000000 -0700
+++ fudapi.inc.php 2012-09-05 10:44:19.000000000 -0700
@@ -722,7 +722,7 @@
'. ssn(htmlspecialchars($vals['home_page'])) .',
'. ssn($vals['bio']) .',
'. (int)$vals['users_opt'] .',
- '. $vals['registration_ip'] .'
+ \''. $vals['registration_ip'] .'\'
)
');
}

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167718 is a reply to message #167717] Thu, 06 September 2012 05:57 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
Looks good.

Please register a users on SourceForge.net so we can grant you commit access.

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167720 is a reply to message #167718] Thu, 06 September 2012 18:41 Go to previous messageGo to next message
DPhan is currently offline  DPhan   United States
Messages: 9
Registered: September 2012
Location: San Jose, Calif
Karma: 0
Junior Member
It appears the private messaging feature is not enabled on this forum. How can I send you my SourceForge username privately?

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167723 is a reply to message #167720] Fri, 07 September 2012 13:53 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
You cannot keep it private. Once we grant you access, SourceForge will identify you as a FUDforum developer.

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167725 is a reply to message #167723] Fri, 07 September 2012 17:56 Go to previous messageGo to next message
DPhan is currently offline  DPhan   United States
Messages: 9
Registered: September 2012
Location: San Jose, Calif
Karma: 0
Junior Member
My SourceForge username is dmphan.

Dan

Report message to a moderator

Re: Newbie question: where to check in bug fix on sourceforge? [message #167729 is a reply to message #167725] Sat, 08 September 2012 15:57 Go to previous message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
Access was granted.

Report message to a moderator

  Switch to threaded view of this topic Create a new topic Submit Reply
Previous Topic: Add a canonical link to the message page
Next Topic: Code fix for the fatal division by zero error if moderator uses "move selected" button
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sat Nov 23 08:01:29 GMT 2024

Total time taken to generate the page: 0.02337 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.1.3.
Copyright ©2001-2023 FUDforum Bulletin Board Software