| Re: Repetetive code question [message #179655 is a reply to message #179646] |
Fri, 16 November 2012 08:11   |
Goran
Messages: 38
Registered: January 2011
Karma:
|
Member |
|
|
On 15.11.2012 16:36, Thomas 'PointedEars' Lahn wrote:
> Goran wrote:
>
>> On 15.11.2012 13:26, Dynamo wrote:
>>> Not sure if this is the right place to ask this question as it is more
>>> an html query than a php one but here goes anyway.
>>>
>>> I have a large chunk of html code that is used to build an extensive
>>> drop down menu. The same code is used on all 30 of my web pages. So I
>>> have seperated the code into a txt file called menu.txt and used the
>>> following php code to get the file contents:
>>> [
>>> <?php
>>> $mymenu=file_get_contents('menu.txt');
>>> echo $mymenu;
>>> ?>
>>> ]
>>> Everthing works fine but is this good practice and is there a better
>>> way.
>>
>> This should be:
>>
>> <?php readfile('menu.html') ?>
>
> How do you know this is not an example and they want to process the file
> contents before writing it to the standard output?
How do I know? Because he wrote it (implicitly) - he already
successfully use "file_get_contents" (this function does not process
local files) + his menu template is called ".txt".
> And there appear to be issues with readfile(), enabled output buffering and
> large files or slow connections. Not so with file_get_contents();
Somehow I don't think simple menu template will cause memory issues.
Guys, stop reinventing the wheel, readfile() is made for this in the
same way as include() is made for including other php skripts.
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]