FUDforum: Plugins and Code Hacks » Proposed code change for potentially more unique sysid

Home » FUDforum Development » Plugins and Code Hacks » Proposed code change for potentially more unique sysid

Show: Today's Messages :: Polls :: Message Navigator

Proposed code change for potentially more unique sysid [message #184644]

Tue, 14 January 2014 15:08

kmoradha
Messages: 8
Registered: January 2014

Karma: 0

Junior Member

Hi, this is my first proposed change, so please let me know if I'm not following the right procedure (I've read the SVN docs on the wiki site).

We were experiencing session collisions for new logins, as the ses_make_sysid() function was not generating unique enough identifiers. We are using basic authentication on our server, so I'm proposing to add REMOTE_USER to the set of environment variables used to uniquely identify the client browser. For installs where basic authentication is not used, this addition will have no impact.

Below is the change...please review and let me know if I can apply for commit access in SourceForge.

--- cookies.inc.t-orig  2014-01-14 09:57:48.986943684 -0500
+++ cookies.inc.t       2014-01-14 09:58:06.153061812 -0500
@@ -15,7 +15,7 @@
                return;
        }

-       $keys = array('HTTP_USER_AGENT', 'SERVER_PROTOCOL', 'HTTP_ACCEPT_CHARSET', 'HTTP_ACCEPT_LANGUAGE');
+       $keys = array('REMOTE_USER', 'HTTP_USER_AGENT', 'SERVER_PROTOCOL', 'HTTP_ACCEPT_CHARSET', 'HTTP_ACCEPT_LANGUAGE');
        if ($GLOBALS['FUD_OPT_3'] & 16) {       // SESSION_IP_CHECK
                $keys[] = 'HTTP_X_FORWARDED_FOR';
                $keys[] = 'REMOTE_ADDR';

Report message to a moderator

Re: Proposed code change for potentially more unique sysid [message #184645 is a reply to message #184644]

Tue, 14 January 2014 15:40

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

Patch looks good, thanks!
What is your sourceforge.net username?

Report message to a moderator

Re: Proposed code change for potentially more unique sysid [message #184646 is a reply to message #184645]

Tue, 14 January 2014 15:46

kmoradha
Messages: 8
Registered: January 2014

Karma: 0

Junior Member

My SourceForge username is "kmoradha". Do I need to do anything special to apply for commit access, or do you just grant it? I can't find a button anywhere on the project page... Smile