FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » Selected and Unselected mix-up?
Show: Today's Messages :: Polls :: Message Navigator
Return to the default flat view Create a new topic Submit Reply
Selected and Unselected mix-up? [message #20933] Wed, 03 November 2004 15:05 Go to previous message
Abraxa is currently offline  Abraxa   Germany
Messages: 72
Registered: August 2004
Location: Germany
Karma:
Member
Heya Ilia =)

I don't know if you did it on purpose or not but I found something that made me wonder a little.
In draw_select_opt.tmpl, you define two sections:

{SECTION: selected_option}
<option value="{VAR: vls[$i]}" {VAR: normal_tmpl}>{VAR: nms[$i]}</option>
{SECTION: END}

{SECTION: unselected_option}
<option value="{VAR: vls[$i]}" selected {VAR: selected_tmpl}>{VAR: nms[$i]}</option>
{SECTION: END}


As you can see, the unselected section has the "selected" property while the selected section doesn't - isn't it supposed to be the other way round, judging from the names you gave the sections?
The mix-up doesn't have any consequences since in draw_select_opt.inc.t you do a "!=" comparison instead of "==" but still I wonder if that's something that maybe should be fixed for reasons of code logic?

(btw, same thing occurs in draw_radio_opt.*)

-Abraxa
[Message index]
 
Read Message
Read Message
Read Message
Previous Topic: SQL error on upgrade
Next Topic: Moderator can't post in password protected forum
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Mon Jul 08 01:42:31 GMT 2024

Total time taken to generate the page: 0.04356 seconds