FUDforum: Bug Reports » Selected and Unselected mix-up?

Home » FUDforum Development » Bug Reports » Selected and Unselected mix-up?

Show: Today's Messages :: Polls :: Message Navigator

Selected and Unselected mix-up? [message #20933]

Wed, 03 November 2004 15:05

Abraxa

Messages: 72
Registered: August 2004
Location: Germany

Karma: 0

Member

Heya Ilia =)

I don't know if you did it on purpose or not but I found something that made me wonder a little.
In draw_select_opt.tmpl, you define two sections:

{SECTION: selected_option}
<option value="{VAR: vls[$i]}" {VAR: normal_tmpl}>{VAR: nms[$i]}</option>
{SECTION: END}

{SECTION: unselected_option}
<option value="{VAR: vls[$i]}" selected {VAR: selected_tmpl}>{VAR: nms[$i]}</option>
{SECTION: END}

As you can see, the unselected section has the "selected" property while the selected section doesn't - isn't it supposed to be the other way round, judging from the names you gave the sections?
The mix-up doesn't have any consequences since in draw_select_opt.inc.t you do a "!=" comparison instead of "==" but still I wonder if that's something that maybe should be fixed for reasons of code logic?

(btw, same thing occurs in draw_radio_opt.*)

-Abraxa

Report message to a moderator