FUDforum: Plugins and Code Hacks

Home » FUDforum Development » Plugins and Code Hacks » CSS patch

Show: Today's Messages :: Polls :: Message Navigator

CSS patch [message #26261]

Tue, 12 July 2005 12:38

ggray

Messages: 96
Registered: October 2004
Location: Crimea: Simferopol

Karma: 0

Member

this patch make view better code in [code][/code] tags, it's remove unneeded scrolls, add some space between text and container and use fixed width.

Code: [Select all] [Show/ hide]

Index: forum.css.tmpl
===================================================================
RCS file: /forum21/install/forum_data/thm/default/tmpl/forum.css.tmpl,v
retrieving revision 1.65
diff -r1.65 forum.css.tmpl
546c546,548
< 	overflow: scroll;
---
> 	overflow: auto;
> 	margin: 5px;
> 	width: 700px;

I think it should be added in CVS, may be without "width: 700px;", what are you think Ilia?

Report message to a moderator

Re: CSS patch [message #26264 is a reply to message #26261]

Tue, 12 July 2005 13:33

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

The change for overlflow to auto is a good idea, the margin is not necessary IMO, since the css already has a padding of 5px and hardcoding the size to 700px does not seem necessary.

FUDforum Core Developer

Report message to a moderator

Re: CSS patch [message #26266 is a reply to message #26264]

Tue, 12 July 2005 13:41

ggray

Messages: 96
Registered: October 2004
Location: Crimea: Simferopol

Karma: 0

Member

padding - space between inner text
margin - space between outer text
margin = padding looks better fo me Wink

, and fixed width - just for for long line witch stretch the page (in current version horizontal scroll never used)

Report message to a moderator

Re: CSS patch [message #26267 is a reply to message #26266]

Tue, 12 July 2005 14:12

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Well, I changed to auto and the scroll does not appear until it is necessary, so the goal is achieved. I see no reason to do inner padding, unless you can provide good reasons showing otherwise.

FUDforum Core Developer

Report message to a moderator

Re: CSS patch [message #26269 is a reply to message #26267]

Tue, 12 July 2005 14:43

ggray

Messages: 96
Registered: October 2004
Location: Crimea: Simferopol

Karma: 0

Member

just look

before:

after:

Report message to a moderator

Re: CSS patch [message #26270 is a reply to message #26269]

Tue, 12 July 2005 14:47

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Not sure what is being shown, but I've changed the overflow to auto in CVS and on my dev forum I no longer get any scroll bars in Firefox, unless there is an actual need for one.

So, I don't see a need to add 700px hard-coded width.

FUDforum Core Developer

Report message to a moderator