FUDforum: Bug Reports » Mlist_msg_id getting cleared when a message is edited

Home » FUDforum Development » Bug Reports » Mlist_msg_id getting cleared when a message is edited

Show: Today's Messages :: Polls :: Message Navigator

Mlist_msg_id getting cleared when a message is edited [message #26623]

Fri, 29 July 2005 12:56

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

Hi,

When u modify a message, its mlist_msg_id is getting cleared, and this wreaks havoc with the mailing list synchronisation.

i had started the post in howto, but i am continuing here since it looks like a bug in the modify code. I would like to know if it can be fixed?

thanks a lot.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26625 is a reply to message #26623]

Fri, 29 July 2005 13:19

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

the problem is that both the post and modify are using the same code, and i think there should some logic inside. If the mlist_msg_id is already present it shouldnt' be set to null.

the code will get simpler if u can just change the algorithm so that fudforum sets its own mlist_msg_id, and does not wait for the mail to get bounced back from the mailing list to do so.

Thanks.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26626 is a reply to message #26623]

Fri, 29 July 2005 13:21

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Yeah, that was a bug, here is the patch that should fix it:
http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=7175

FUDforum Core Developer

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26630 is a reply to message #26626]

Fri, 29 July 2005 13:38

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

MY post.php.t seems to be cvs version 1.136, which is i think the version in the fud-2.6.15, so how do i jump to 1.142?

Thanks.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26631 is a reply to message #26630]

Fri, 29 July 2005 13:42

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

You download the full file...

FUDforum Core Developer

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26632 is a reply to message #26631]

Fri, 29 July 2005 13:46

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

Ok no problem. But shouldn't the whole fudforum also be updated, else, wouldn't there be some dependency inside post.php.t for the newer version of the other files.

Thanks.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26633 is a reply to message #26623]

Fri, 29 July 2005 13:48

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

and i guess, i have to rebuild the theme too, right?

Thanks.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26635 is a reply to message #26633]

Fri, 29 July 2005 13:50

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Yes, you need to rebuild the theme when code or templates are modified.

FUDforum Core Developer

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26636 is a reply to message #26635]

Fri, 29 July 2005 14:03

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

It does not seem to work. I rebuilt both the default theme and the current theme, but it is still clearing the mlist_msg_id...

btw, is it possible to rewrite it Mesage-id generated by fudforum itself, rather than wait for the mail to bounce back?

Thanks.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26637 is a reply to message #26623]

Fri, 29 July 2005 14:04

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

OOps. wait. i think i rebuilt the theme in a local forum, rather than the main one.

i have two identical forums, and it gets confusing. Let me try the proper and i will get back to u.

Thanks.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26638 is a reply to message #26623]

Fri, 29 July 2005 14:20

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

Ok stuff works. nice. Is there any possibility that the code will be rewritten with msg_id generated inside fud_forum itself?

thanks a lot.

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26639 is a reply to message #26638]

Fri, 29 July 2005 14:24

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

It is a trivial hack if you want to add it, just add the necessary header line inside mail_list_post() found inside include/mlist_post.inc file.

I don't see a particular reason why the forum should be the one to set this id, unless you can provide convincing reasons to show otherwise.

FUDforum Core Developer

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26640 is a reply to message #26639]

Fri, 29 July 2005 14:52

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

Ilia wrote on Fri, 29 July 2005 10:24

It is a trivial hack if you want to add it, just add the necessary header line inside mail_list_post() found inside include/mlist_post.inc file.

I don't see a particular reason why the forum should be the one to set this id, unless you can provide convincing reasons to show otherwise.

Code becomes much more simpler. There is no need to wait for the mail to come back till the mlist_msg_id is set. i think the overall architecture would improve. That is all.

[Updated on: Fri, 29 July 2005 14:52]

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26642 is a reply to message #26640]

Fri, 29 July 2005 17:59

Ilia

Messages: 13241
Registered: January 2002

Karma: 0

Senior Member
Administrator
Core Developer

Try this patch:
http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=7178

it should do what you were looking for.

FUDforum Core Developer

Report message to a moderator

Re: Mlist_msg_id getting cleared when a message is edited [message #26646 is a reply to message #26642]

Fri, 29 July 2005 18:24

ligesh

Messages: 63
Registered: July 2005

Karma: 0

Member

Ilia wrote on Fri, 29 July 2005 13:59

Try this patch:
http://cvs.prohost.org/c/index.cgi/FUDforum/chngview?cn=7178

it should do what you were looking for.

Hey that's cool, and very fast. Thanks.

Report message to a moderator

Previous Topic:	Problem with registering new users
Next Topic:	403 Forbidden when posting

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Nov 12 19:53:05 GMT 2024

Total time taken to generate the page: 0.02588 seconds