FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.
Home » FUDforum » FUDforum Suggestions » FUDCode for URL's
Show: Today's Messages :: Polls :: Message Navigator
Switch to threaded view of this topic Create a new topic Submit Reply
FUDCode for URL's [message #29197] Sat, 03 December 2005 13:30 Go to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
Hi,

People tend to enclose URLs in "quotes". Can this somehow be accommodated as valid FUDcode?

Example:

[ url="http://www.google.com" ]Google[ /url ] - Google (bad link)

instead of

[ url=http://www.google.com ]Google[ /url ] - Google

Best regards.

Frank

Report message to a moderator

Re: FUDCode for URL's [message #29198 is a reply to message #29197] Sat, 03 December 2005 17:09 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Attributes in FUDforum do not allow double quotes to be used.

FUDforum Core Developer

Report message to a moderator

Re: FUDCode for URL's [message #29200 is a reply to message #29198] Sat, 03 December 2005 19:21 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
Thank you for the reply. Unfortunately many BBCode variants support double quoted attributes. So, users mistakenly use them all the time.

Report message to a moderator

Re: FUDCode for URL's [message #29202 is a reply to message #29200] Sat, 03 December 2005 22:49 Go to previous messageGo to next message
Wild_Cat is currently offline  Wild_Cat   Ukraine
Messages: 144
Registered: November 2002
Location: Odessa, Ukraine
Karma: 0
Senior Member
The idea to quote the URL in a BBCode would not come into my head even though I'm a web-master (and only in this case I can imagine why someone would put quotes around an URL since when it's not mandatory it's only typing 2 chars less and that's good I don't have to!) Very Happy
Not to speak about possible security violation? when it's an url without quotes that's only it whilst who know what can be put into quotes! And FUDforum has a strong emphasis on security which distinguishes it.

Lady of Avalon

Report message to a moderator

Re: FUDCode for URL's [message #29208 is a reply to message #29202] Sun, 04 December 2005 08:30 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
The proposal is for the double quotes to be stripped from the attribute tags.

So, you don't have to type them in. However, users that do should be accommodated.

Report message to a moderator

Re: FUDCode for URL's [message #29212 is a reply to message #29200] Sun, 04 December 2005 16:29 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Most people try to avoid typing thing they don't have to, so quoting attributes is something most people won't do unless forced. Furthermore the shortcut links do not use them.

FUDforum Core Developer

Report message to a moderator

Re: FUDCode for URL's [message #29219 is a reply to message #29212] Sun, 04 December 2005 17:21 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
Maybe it just me then, but I'm sick of all the invalid links on my site caused by FUDForum. If anyone else is interested in a patch, just let me know.

Report message to a moderator

Re: FUDCode for URL's [message #29220 is a reply to message #29219] Sun, 04 December 2005 20:35 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
Here is a patch that will fix this problem:

--- post_proc.inc.t?v=1.81      2005-12-04 14:32:37.000000000 -0600
+++ post_proc.inc.t     2005-12-04 14:33:17.000000000 -0600
@@ -148,6 +148,7 @@
                                                $url = $parms;
                                        }

+                                       $url = str_replace('"', '', $url); // Remove quotes from URL
                                        $url = url_check($url);

                                        if (!strncasecmp($url, 'www.', 4)) {

Report message to a moderator

Re: FUDCode for URL's [message #29266 is a reply to message #29220] Tue, 06 December 2005 19:42 Go to previous messageGo to next message
Wild_Cat is currently offline  Wild_Cat   Ukraine
Messages: 144
Registered: November 2002
Location: Odessa, Ukraine
Karma: 0
Senior Member
Yeah, reading previous post I actually thought it's quite easy to mlement (unless there are any "rakes" in stripping exactly whis way & quote I mean!
This could be easily addres to release IMHO (although I never ran into this sort of problem on my forum, yu must be having crazy users Wink )

And what does the url_check() function do?
I don't have the code under my hands but I don't think it actually verifies accessibility of the given url. May be it does check it for ilegal chars or whatever, may be this quote check should be placed there instead? And may be some more useless chars should be checked for, unless it's exactly what check_url() does....

Just giving some ideas.

Lady of Avalon

Report message to a moderator

Re: FUDCode for URL's [message #29268 is a reply to message #29266] Tue, 06 December 2005 21:24 Go to previous message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
url_check() function deals with htmlentities found in the URL.

FUDforum Core Developer

Report message to a moderator

  Switch to threaded view of this topic Create a new topic Submit Reply
Previous Topic: View my attachments tab
Next Topic: a tiny suggestion: moderators and administrators
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sun Dec 01 00:06:55 GMT 2024

Total time taken to generate the page: 0.04118 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.1.3.
Copyright ©2001-2023 FUDforum Bulletin Board Software