FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Bug Reports » urlencoding in some titles
Show: Today's Messages :: Polls :: Message Navigator
Switch to threaded view of this topic Create a new topic Submit Reply
urlencoding in some titles [message #33624] Mon, 11 September 2006 13:39 Go to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member

there is one small issue - urlencoding on some titles? for example on my MSN image:
gurugray%40hotmail.com

Rolling Eyes
Re: urlencoding in some titles [message #33633 is a reply to message #33624] Mon, 11 September 2006 14:05 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Yeah... I suppose we could call urldecode() on the title value, but to me this seems so trivial, its not worth dealing with at an expense of an extra function call. That said if you want to change it on your forum, you need to edit 2 templates, drawmsg.tmpl and drawpmsg.tmpl and change

<a href="mailto: {VAR: obj->msnm}"><img alt="" src="{THEME_IMAGE_ROOT}/msnm{DEF: img_ext}" title="{VAR: obj->msnm}" /></a>


to

<a href="mailto: {VAR: obj->msnm}"><img alt="" src="{THEME_IMAGE_ROOT}/msnm{DEF: img_ext}" title="{FUNC: urldecode($obj->msnm)}" /></a>


FUDforum Core Developer
Re: urlencoding in some titles [message #33659 is a reply to message #33633] Tue, 12 September 2006 11:07 Go to previous messageGo to next message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member

so what about original forum patch? Wink

and

May be we need to store nonecoded value in the DB, and encode it only when needed, on "mailto:" links for example?

[Updated on: Tue, 12 September 2006 11:07]

Report message to a moderator

Re: urlencoding in some titles [message #33663 is a reply to message #33659] Tue, 12 September 2006 14:42 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
The reason FUDforum stores the urlencoded value is to avoid having to do a real-time encoding, thus reducing the work that needs to be done. By the forum, perhaps one solution would be to use htmlencoding() that should work fine inside the title attribute.

This is something to be investigated...


FUDforum Core Developer
Re: urlencoding in some titles [message #33666 is a reply to message #33663] Tue, 12 September 2006 15:14 Go to previous messageGo to next message
Ilia is currently offline  Ilia   Canada
Messages: 13241
Registered: January 2002
Karma: 0
Senior Member
Administrator
Core Developer
Looks to be working, I've set it up for MSN and Google messengers that use e-mails for logins.

FUDforum Core Developer
Re: urlencoding in some titles [message #33680 is a reply to message #33624] Wed, 13 September 2006 13:28 Go to previous message
ggray is currently offline  ggray   Ukraine
Messages: 96
Registered: October 2004
Location: Crimea: Simferopol
Karma: 0
Member

great Smile
  Switch to threaded view of this topic Create a new topic Submit Reply
Previous Topic: SQL error at first loading everytime
Next Topic: what's error ?
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Sun Nov 24 21:06:42 GMT 2024

Total time taken to generate the page: 0.02719 seconds