| Minor layout suggestions [message #36253] |
Sat, 10 March 2007 17:46  |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
|
|
1) I noticed that there is an additional blank line before the tab row if I click on "Show Own Posts", but not on the other pages I can reach with the tab menu. I think that is a bit irritating.
2) If there are no messages in a forum then there is a corresponding text shown ("There are no messages in this forum."). But I in my opinion the position where this text appears (above the table of the thread listing) is strange.
I attached a patch with my suggested changes for each issue.
|
|
|
|
| Re: Minor layout suggestions [message #36265 is a reply to message #36253] |
Sun, 11 March 2007 18:47  |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
|
|
The showposts tweak is a good idea, I've applied it to the CVS.
The second is a bit problematic since it breaks HTML, you are putting a span into a <table> tag without the appropriate <tr><td> block.
FUDforum Core Developer
|
|
|
|
| Re: Minor layout suggestions [message #36296 is a reply to message #36253] |
Wed, 14 March 2007 17:09 |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
|
|
You are right, the second patch is bad. I have now attached a completely new patch which should contain a better solution. While testing my patch I have found some HTML errors, my suggested changes for these are also in this patch.
By the way, is there currently a problem with the CVS server, I can't access it at the moment?
[Updated on: Wed, 14 March 2007 17:27] Report message to a moderator |
|
|
|
| Re: Minor layout suggestions [message #36351 is a reply to message #36296] |
Sun, 18 March 2007 18:24 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
|
|
I've applied some of the suggested fixes, the no results bit, hiding of empty next/prev links, and double tag close.
I didn't include the removal tag close link bit from <link> tag and the alt tag addition.
FUDforum Core Developer
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]