Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #427] |
Tue, 12 February 2002 15:34 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
this error when I omitted my birthday data... my SQL tool told me that bday cannot be NULL, when I tried to manually do the insert.
When I replaced my NULL bday with 1, it committed.
Quote: | Query Failed: INSERT INTO fud_users ( login, passwd, name, email, display_email, notify, notify_method, ignore_admin, private_messages, gender, icq, aim, yahoo, msnm, append_sig, posts_ppg, time_zone, bday, invisible_mode, last_visit, conf_key, user_image, join_date, location, avatar, style, coppa, occupation, interests, referer_id, show_sigs, last_read, avatar_loc, avatar_approved, sig, show_tool_tips, default_view ) VALUES ( 'Garth', 'ce81c61e53db9cbaf7cc3ceee60dcfea', 'Garth', 'Garth(at)email(dot)com', 'Y', 'N', 'EMAIL', 'N', 'Y', '', NULL, NULL, NULL, NULL, 'Y', '0', 'America/Montreal', NULL, 'N', 1013526931, 'b5b4970762fcfc632b0f6c726db5d8b9', NULL, 1013526931, '', 0, 1, 'N', NULL, NULL, 1, 'Y', 1013526931, NULL, 'NO', NULL, 'N', 'msg' ) Reason: From: f:/php4/!forums/htdocs/register.php
|
Update: No matter if I put my birthday stuff in or not the SQL gets a NULL for bday and crashes out...
[Updated on: Tue, 12 February 2002 16:10] Report message to a moderator
|
|
|
Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) #2 [message #428 is a reply to message #427] |
Tue, 12 February 2002 16:07 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
On forums with anonymous posting turned off I get this error when I try to create a thread.
Quote: | Query Failed: UPDATE fud_ses SET sys_id='0', time_sec=1013529183, data='00000004 err_id0000003243233a856b9423e1963d6c40de684d12 er_msg00000284Annonymous users aren't allowed to reply<br><br>If you would like to register go to the <a href="register.php?S=7b77c4dfeeac9501690d6745 97bb6aa5">registration form</a><br>If you would like to login please go to the <a href="login.php?S=7b77c4dfeeac9501690d674597b b6aa5">login form</a> err_t00000031ERROR: Insufficient Priviledges ret_to00000072dGhyZWFkLnBocD9mcm1faWQ9MiZTPTdiNzdj NGRmZWVhYzk1MDE2OTBkNjc0NTk3YmI2YWE1' WHERE id=11 Reason: You have an error in your SQL syntax near 't allowed to reply
If you would like to register go to the <a href="regis' at line 1 From: f:/php4/!forums/htdocs/post.php
|
Is this page supposed to render a different then it does? It looks like there is some HTML in there.
[Updated on: Tue, 12 February 2002 16:11] Report message to a moderator
|
|
|
Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) #3 [message #429 is a reply to message #428] |
Tue, 12 February 2002 16:28 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
Anonymous Uploading fails:
Quote: | Query Failed: INSERT INTO fud_attach ( proto, location, original_name, message_id, owner, private ) VALUES( 'LOCAL', 'none://unset', 'th_9.dat', 13, , 'N' ) Reason: You have an error in your SQL syntax near ' 'N' )' at line 14 From: f:/php4/!forums/htdocs/post.php
|
The value for the owner field is not set causing the SQL to bomb out.
|
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #431 is a reply to message #427] |
Tue, 12 February 2002 16:33 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
ironstorm wrote on Tue, 12 February 2002 10:34 AM | this error when I omitted my birthday data... my SQL tool told me that bday cannot be NULL, when I tried to manually do the insert.
When I replaced my NULL bday with 1, it committed.
Quote: | Query Failed: INSERT INTO fud_users ( login, passwd, name, email, display_email, notify, notify_method, ignore_admin, private_messages, gender, icq, aim, yahoo, msnm, append_sig, posts_ppg, time_zone, bday, invisible_mode, last_visit, conf_key, user_image, join_date, location, avatar, style, coppa, occupation, interests, referer_id, show_sigs, last_read, avatar_loc, avatar_approved, sig, show_tool_tips, default_view ) VALUES ( 'Garth', 'ce81c61e53db9cbaf7cc3ceee60dcfea', 'Garth', 'Garth(at)email(dot)com', 'Y', 'N', 'EMAIL', 'N', 'Y', '', NULL, NULL, NULL, NULL, 'Y', '0', 'America/Montreal', NULL, 'N', 1013526931, 'b5b4970762fcfc632b0f6c726db5d8b9', NULL, 1013526931, '', 0, 1, 'N', NULL, NULL, 1, 'Y', 1013526931, NULL, 'NO', NULL, 'N', 'msg' ) Reason: From: f:/php4/!forums/htdocs/register.php
|
Update: No matter if I put my birthday stuff in or not the SQL gets a NULL for bday and crashes out...
|
Bug fixed it latest cvs, (grab forum_install/install_data/sys/include/users_reg.inc)
it should fix the problem.
FUDforum Core Developer
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #432 is a reply to message #429] |
Tue, 12 February 2002 16:47 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
ironstorm wrote on Tue, 12 February 2002 11:28 AM |
Anonymous Uploading fails:
Quote: | Query Failed: INSERT INTO fud_attach ( proto, location, original_name, message_id, owner, private ) VALUES( 'LOCAL', 'none://unset', 'th_9.dat', 13, , 'N' ) Reason: You have an error in your SQL syntax near ' 'N' )' at line 14 From: f:/php4/!forums/htdocs/post.php
|
The value for the owner field is not set causing the SQL to bomb out.
|
Fixed in latest CVS (grab forum_install/install_data/sys/include/attach.inc)
FUDforum Core Developer
|
|
|
Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) #5 [message #434 is a reply to message #427] |
Tue, 12 February 2002 16:58 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
Every Message or Edit has the entire of the thread prepended.
When you create thread, each reply in thread prepends all of the body of text from all the previous messages.
The same is true of edits.
Also nested replys aren't displayed at all, unless they are at the end of a thread (in which case they appear as normal replies).
I suspect this is a windows only type problem, problaby something to do with where you store the end of one message and the start of another (like if it's just counting lines and storing that in a DB and \n needs to be \r\n or something for windows)
Anyway, I'm going to see if I can figure out where I need to look for this this afternoon if I get the chance. (I'm guessing I need to start with POST.PHP or MSG.PHP)
Attached is a thread of edits and replys... please let me know if there is anything out of the ordinary about it's contents.
-
Attachment: th_9.zip
(Size: 0.16KB, Downloaded 1018 times)
[Updated on: Tue, 12 February 2002 17:04] Report message to a moderator
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #435 is a reply to message #428] |
Tue, 12 February 2002 17:17 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
ironstorm wrote on Tue, 12 February 2002 11:07 AM | On forums with anonymous posting turned off I get this error when I try to create a thread.
Quote: | Query Failed: UPDATE fud_ses SET sys_id='0', time_sec=1013529183, data='00000004 err_id0000003243233a856b9423e1963d6c40de684d12 er_msg00000284Annonymous users aren't allowed to reply<br><br>If you would like to register go to the <a href="register.php?S=7b77c4dfeeac9501690d6745 97bb6aa5">registration form</a><br>If you would like to login please go to the <a href="login.php?S=7b77c4dfeeac9501690d674597b b6aa5">login form</a> err_t00000031ERROR: Insufficient Priviledges ret_to00000072dGhyZWFkLnBocD9mcm1faWQ9MiZTPTdiNzdj NGRmZWVhYzk1MDE2OTBkNjc0NTk3YmI2YWE1' WHERE id=11 Reason: You have an error in your SQL syntax near 't allowed to reply
If you would like to register go to the <a href="regis' at line 1 From: f:/php4/!forums/htdocs/post.php
|
Is this page supposed to render a different then it does? It looks like there is some HTML in there.
|
Fixed in latest CVS.
grab( forum_install/install_data/sys/include/error.inc & forum_install/install_data/sys/include/cookies.inc )
FUDforum Core Developer
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #436 is a reply to message #430] |
Tue, 12 February 2002 17:46 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
ironstorm wrote on Tue, 12 February 2002 11:31 AM |
Files with no extension can't be uploaded even when '*' is the type of files being accepted.
Quote: | The file you are trying to upload doesn't match the allowed file types. Allowed File Types: * Maximum File Size 1024Kb Maximum Files per Message: 10
|
This is the message I got from trying to upload th_9 data up to the message board.
|
Fixed in latest CVS. This change actually affects a number of files, so you might as well get the entire CVS tree.
P.S. After you do that, if you allow for * files, go into your settings directory and delete everything from the file_filter_regexp file.
FUDforum Core Developer
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #437 is a reply to message #434] |
Tue, 12 February 2002 17:53 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
ironstorm wrote on Tue, 12 February 2002 11:58 AM | Every Message or Edit has the entire of the thread prepended.
When you create thread, each reply in thread prepends all of the body of text from all the previous messages.
The same is true of edits.
Also nested replys aren't displayed at all, unless they are at the end of a thread (in which case they appear as normal replies).
I suspect this is a windows only type problem, problaby something to do with where you store the end of one message and the start of another (like if it's just counting lines and storing that in a DB and \n needs to be \r\n or something for windows)
Anyway, I'm going to see if I can figure out where I need to look for this this afternoon if I get the chance. (I'm guessing I need to start with POST.PHP or MSG.PHP)
Attached is a thread of edits and replys... please let me know if there is anything out of the ordinary about it's contents.
|
I cannot replicate this bug on Linux, so I am guessing your assumption about this being a windows only bug is correct. We do not count lines, but rather go by offsets in the file, so \r & \n should have not impact on the reading code. The 2 files you may want to look at are fileio.inc & msg_edt.inc they contain all of the code which actually writes/reads messages to/from disk.
Could you pleaserun the following query in MySQL and attach its output to your reply.
SELECT * FROM fud_msg WHERE thread_id=9;
FUDforum Core Developer
|
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #439 is a reply to message #438] |
Tue, 12 February 2002 18:54 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
Already see the problem.
It would appear that for whatever reason the offset for each message is 0, which makes it read all of the data prior to this message in the thread.
Could you please give me the URL to your forum, I want to see this problem realtime if possible.
Thanks.
FUDforum Core Developer
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #440 is a reply to message #427] |
Tue, 12 February 2002 19:43 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
Okie, the lastest CVS should have a fix for this.
The problem was entirely Windows' fault. In windows when you open file for append ftell() will always return 0 unless you write some data to the file. Our code being UNIX centric got the start position of the message by doing an ftell(). Windows programmers consider this a "feature" of NTFS' implementation of file permissions. Since NTFS allows a (real append) permission you cannot overwrite data before you aquired the file in append mode. We've added a filesize() hack to hopeful solve this bug in Windows.
(grab forum_install/install_data/sys/include/post.inc & forum_install/install_data/sys/include/private.inc)
To test the fix you'll need to create new threads, the old ones that were affected by this problem cannot be fixed.
FUDforum Core Developer
|
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #442 is a reply to message #439] |
Tue, 12 February 2002 20:31 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
prottoss wrote on Tue, 12 February 2002 1:54 PM |
Could you please give me the URL to your forum, I want to see this problem realtime if possible.
|
Regrettably, the board I'm working on is behind a firewall, so it's not accessible from the outside world.
Nor am I able to easily CVS the new files down...
I'd be greatful if you or hackie could post these files from CVS... (If you read this before 5pm, otherwise, I'll test them tomorrow for sure)
prottoss wrote on Tue, 12 February 2002 2:43 PM |
(grab forum_install/install_data/sys/include/post.inc & forum_install/install_data/sys/include/private.inc)
|
|
|
|
|
|
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #452 is a reply to message #448] |
Wed, 13 February 2002 02:04 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
prottoss wrote on Tue, 12 February 2002 4:14 PM |
ironstorm wrote on Tue, 12 February 2002 4:10 PM | many thanks
|
You're welcome...
The http://fud.prohost.org/download/forum-dev-20020212.tar.gz release should be installable on Windows without needing to modify your include_path and the only thing that would be still relavent from your previous problems would be the SMTP setup on Windows.
P.S. Perphaps, we need to setup some automatic snapshot script, that would make snapshots every few hours or so...
|
er sorry, I typed up a message... I must have deleted it or something right before I posted....
I was just going to say I'll install that snapshot on the DragonX.northern.ca dev machine. When I get home... (which I'm home now ).
And I was saying the CVS thing is a both a good and a bad idea, good cause it fixes bugs, bad cause sometimes it can discourage releasing as often (which might be a good or a bad thing in itself depending wheither your after higher quailty or higher visbility marketing )
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #453 is a reply to message #427] |
Wed, 13 February 2002 02:52 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
Quote: | function add($owner, $message_id, $original_name, $cur_location, $private='') { $proto = proto($cur_location); Q("INSERT INTO fud_attach (proto, location, original_name, message_id, owner, private) VALUES('$proto', 'none://unset', '$original_name', ".INTZERO($message_id).", INTZERO($owner), '".YN($private)."')"); $id = DB_LASTID(); $this->message_id=$message_id; if ( $proto == 'LOCAL' ) { $loc = safe_attachment_copy($cur_location, $id); }
|
Got an extra " in your SQL in attach.inc
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #454 is a reply to message #453] |
Wed, 13 February 2002 02:53 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
ironstorm wrote on Tue, 12 February 2002 9:52 PM |
Quote: | function add($owner, $message_id, $original_name, $cur_location, $private='') { $proto = proto($cur_location); Q("INSERT INTO fud_attach (proto, location, original_name, message_id, owner, private) VALUES('$proto', 'none://unset', '$original_name', ".INTZERO($message_id).", INTZERO($owner), '".YN($private)."')"); $id = DB_LASTID(); $this->message_id=$message_id; if ( $proto == 'LOCAL' ) { $loc = safe_attachment_copy($cur_location, $id); }
|
Got an extra " in your SQL in attach.inc
|
Or rather perhaps one too few...
don't know... the quotes look messed up for the whole line.
[Updated on: Wed, 13 February 2002 02:54] Report message to a moderator
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #455 is a reply to message #454] |
Wed, 13 February 2002 02:55 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
Already see the problem, it should be:
Q("INSERT INTO fud_attach (proto, location, original_name, message_id, owner, private) VALUES('".$proto."', 'none://unset', '".$original_name."', ".INTZERO($message_id).", ".INTZERO($owner).", '".YN($private)."')");
You can get attach.inc from CVS it'll fix the problem. Or simply replace the code you got in your attach.inc with the code I showed above.
FUDforum Core Developer
[Updated on: Wed, 13 February 2002 02:57] Report message to a moderator
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #456 is a reply to message #455] |
Wed, 13 February 2002 03:00 |
ironstorm
Messages: 89 Registered: February 2002 Location: Toronto, Ontario, Canada
Karma: 0
|
Member |
|
|
Yup... that's what I did... was about to post it
Quote: | Q("INSERT INTO fud_attach (proto, location, original_name, message_id, owner, private) VALUES('$proto', 'none://unset', '$original_name', ".INTZERO($message_id).",'". INTZERO($owner)."','".YN($private)."')");
|
|
|
|
|
|
|
|
|
|
Re: Bugs in 1.1.9-dev (from CVS @ 8:30am Feb 12) [message #464 is a reply to message #463] |
Wed, 13 February 2002 05:19 |
Ilia
Messages: 13241 Registered: January 2002
Karma: 0
|
Senior Member Administrator Core Developer |
|
|
Back to the drawing table....
I need to go read docs on uploading binary files in Windows using PHP, there is something I am CLEARLY missing here.
FUDforum Core Developer
|
|
|
|
|
|
|
|
|
|
|