FUDforum: comp.lang.php » mysql_fetch

Home » Imported messages » comp.lang.php » mysql_fetch_array

Show: Today's Messages :: Polls :: Message Navigator

Re: mysql_fetch_array [message #169809 is a reply to message #169808]

Mon, 27 September 2010 13:35

Captain Paralytic
Messages: 204
Registered: September 2010

Karma:

Senior Member

On 27 Sep, 14:18, MikeB <mpbr...@gmail.com> wrote:
> matt wrote:
>> On Sep 25, 4:28 pm, MikeB<mpbr...@gmail.com> wrote:
>>> I have the following code:
>
>>> $query = "SELECT * FROM classics";
>>> $result = mysql_query($query);
>
>>> if (!$result) die ("Database access failed: " . mysql_error());
>>> $rows = mysql_num_rows($result);
>
>>> for ($j = 0 ; $j< $rows ; ++$j)
>>> {
>>> $results[] = mysql_fetch_array($result);
>
>>> }
>
>> This doesn't make much sense to me, unless you need the value of $rows
>> later on...
>
>> how about this instead:
>
>> if (!$result = mysql_query("..."))
>> die ("...");
>
>> while ($row = mysql_fetch_array($result))
>> $results[] = $row;
>
>> You're defining two additional variables that are totally unneeded.
>> Of course some pedant is probably going to jump down my throat for
>> putting assignments in my conditionals...
>
> How efficient is it to call the mysql_fetch_array($result) function
> every time for the the loop evaluation vs.comparing with a variable
> that is set once?

You have me completely confused now!!!

Surely:
> for ($j = 0 ; $j < $rows ; ++$j)
> {
> $results[] = mysql_fetch_array($result);
> }
also calls mysql_fetch_array($result) just as many times as the other
one (OK one less, but you make up for that by calling
mysql_num_rows($result)).

Since in order to use the contents of $results[] you have to execute
another loop, I'm sure you can work out which is the more efficient.

Report message to a moderator

[Message index]

		mysql_fetch_array By: MikeB on Sat, 25 September 2010 20:28
		Re: mysql_fetch_array By: Marious Barrier on Sat, 25 September 2010 21:08
		Re: mysql_fetch_array By: TechieOldFox on Sat, 25 September 2010 21:50
		Re: mysql_fetch_array By: Captain Paralytic on Sat, 25 September 2010 22:50
		Re: mysql_fetch_array By: MikeB on Sat, 25 September 2010 23:36
		Re: mysql_fetch_array By: Captain Paralytic on Sun, 26 September 2010 11:44
		Re: mysql_fetch_array By: sheldonlg on Sun, 26 September 2010 23:24
		Re: mysql_fetch_array By: The Natural Philosoph on Mon, 27 September 2010 07:15
		Re: mysql_fetch_array By: sheldonlg on Mon, 27 September 2010 12:23
		Re: mysql_fetch_array By: Hamish Campbell on Mon, 27 September 2010 07:44
		Re: mysql_fetch_array By: matt[1] on Mon, 27 September 2010 12:37
		Re: mysql_fetch_array By: MikeB on Mon, 27 September 2010 13:18
		Re: mysql_fetch_array By: Captain Paralytic on Mon, 27 September 2010 13:35
		Re: mysql_fetch_array By: MikeB on Mon, 27 September 2010 14:12

Previous Topic:	Group sort syntax?
Next Topic:	Code to create a cookie in PHP

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sun Oct 20 05:33:36 GMT 2024

Total time taken to generate the page: 0.07410 seconds