| Re: i getting this warning [message #176019 is a reply to message #176017] |
Wed, 16 November 2011 15:11   |
Denis McMahon
Messages: 634
Registered: September 2010
Karma:
|
Senior Member |
|
|
On Wed, 16 Nov 2011 06:56:21 -0500, Jerry Stuckle wrote:
> On 11/16/2011 6:17 AM, sri kanth wrote:
>> $qs=$_REQUEST['id'];
>> $data=mysql_query("select * from tbl_porduct where pid=$qs");
> Three things.
You missed "using unescaped user input in a query with no validation or
verification". I know it's only a select, but would you bet that he's
that sloppy with selects and yet rigorous with data changing statements?
I suspect his code would do something unexpected (by him anyway) if I
sent a get for http://host/page?id=*, as I suspect he only expects the
query to return a single row. ;)
Perhaps a check that the number of rows returned by the query was however
many he expected after checking that the query didn't fail would be a
good thing too?
Rgds
Denis McMahon
|
|
|
|
Calendar
Search
Help
Members
Register
Login
Home
]