FUDforum: comp.lang.php » values not changing

Home » Imported messages » comp.lang.php » values not changing

Show: Today's Messages :: Polls :: Message Navigator

Re: values not changing [message #181566 is a reply to message #181557]

Wed, 22 May 2013 00:32

David Robley
Messages: 23
Registered: March 2013

Karma:

Junior Member

richard wrote:

> www.mroldies.net
>
> I am attempting to change the play list given the year selected.
> However, regardless of which year is chosen, the code selects only the
> originally loaded playlist.
>
> What am I missing?
>
>
>
> <?php
>
> $year=$_GET["year"];
> if (empty($year)) {$year=1900;}
> $year=(int)$year;
>
> echo $year;
>
> if ($year=1900)
> {echo '<iframe width="800" height="800" src="test2.php"
> frameborder="0"></iframe>';}
>
> if ($year>1900)
> {
> /* connect to the db */
> $con = mysql_connect('localhost','user','pass');
>
>
> if (!$con){die("can not connect: " . mysql_error());}
>
> mysql_select_db('richbull_top100',$con);
>
> while ($number<=10):
> $result = mysql_query("SELECT atitle,artist,avid FROM A$year WHERE id =
> $number");
> if (!$result) { echo 'Could not run query: ' . mysql_error(); exit; }

<SNIP> rest of script

In addition to the problems mentioned by others:

you haven't initialised $number for use in the while loop;

the above while loop causes a number of queries to be run, instead you could
use BETWEEN in the query to select matching records for values of id BETWEEN
n and 10;

you have no graceful handling of an error when running a query - the script
just dies

--
Cheers
David Robley

Useless Invention: Soap Dissolver.

Report message to a moderator

[Message index]

		values not changing By: richard on Tue, 21 May 2013 18:17
		Re: values not changing By: Christoph Becker on Tue, 21 May 2013 18:45
		Re: values not changing By: Denis McMahon on Tue, 21 May 2013 21:17
		Re: values not changing By: Thomas 'PointedEars' on Tue, 21 May 2013 22:22
		Re: values not changing By: Thomas 'PointedEars' on Tue, 21 May 2013 22:30
		Re: values not changing By: Thomas 'PointedEars' on Tue, 21 May 2013 22:32
		Re: values not changing By: Doug Miller on Tue, 21 May 2013 22:23
		Re: values not changing By: Peter H. Coffin on Wed, 22 May 2013 02:46
		Re: values not changing By: richard on Wed, 22 May 2013 03:40
		Re: values not changing By: Doug Miller on Wed, 22 May 2013 10:34
		Re: values not changing By: Scott Johnson on Wed, 22 May 2013 12:41
		Re: values not changing By: David Robley on Wed, 22 May 2013 00:32

Previous Topic:	insert PDF table in database
Next Topic:	Got it working finally

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Wed Nov 27 08:41:08 GMT 2024

Total time taken to generate the page: 0.03639 seconds