FUDforum: FUDforum 3.0+ » FUDforum and valid HTML

Home » FUDforum Development » FUDforum 3.0+ » FUDforum and valid HTML

Show: Today's Messages :: Polls :: Message Navigator

Re: FUDforum and valid HTML [message #35331 is a reply to message #33527]

Fri, 29 December 2006 16:18

JanRei

Messages: 361
Registered: October 2005
Location: Germany

Karma:

Senior Member
Contributing Core Developer
Translator

I have attached a patch with suggestions for making the Admin Control Panel more w3c compliant.
Sorry that it took so long, but is was not as easy as I thought. I have found some problems in the Admin Control Panel that I can't fix because of limited knowledge...

I have nearly changed all files in adm folder, I couldn't check admspell.php because the option is not available in my installation.

My changes:

I have tried to do some kind of hack to make the phpinfo page looking better. In order to achieve this I have removed the style information from phpinfo and put some of it in adm.css. This is not optimal solution I think, it also makes all images in Admin Control Panel to be right aligned. Maybe you have a better idea?
I added alt descriptions to images because validator wants to have them.
Where new white pages are displayed in some situations I added code so that the output is valid html, which makes the code look more complex. I also added page title and doctype to the Control Panel.
Validator wanted that <table></table> is within <form></form>. The according changes led to a noticable layout change in admuser.php, which I couldn't fix.

Some things that attracted my attention, but I couldn't fix:

On some pages errors are display simply be executing echo 'error message'. This makes the whole page being invalid html. I couldn't find out how to make better output of error messages.
tmpllist.php produces a strange sorting sometimes. When I expand a template it is put at the beginning of the list, so far it is OK. However, when I expand more templates suddenly all expanded templates are put to the end of the list. Why this?
In admnntp.php there is a empty <select></select> in case there are no forums that can be used for the mailing list. I would suggest to give out a error message here instead.

There is a MySQL query error in case I want to add a avatar without a description:

(C:\xampp\htdocs\FUDforum\include\theme\default\db.inc:72
C:\xampp\htdocs\forum\adm\admavatar.php:129
) 1048: Column 'descr' cannot be null
Query: INSERT INTO fud26_avatar (img, descr, gallery) VALUES ('water.jpg', NULL, 'default')
_POST: array ( 'S' => 'a95ffac3efb349f502d4d79ec39979c5', 'SQ' => '7dee05e7f1bf24209729cc6907545c8d', 'gallery_path' => '', 'tmp_f_val' => '1', 'avt_descr' => '', 'avt_gal_m' => '', 'avt_img' => 'water.jpg', 'btn_submit' => 'Add Avatar', 'edit' => '', )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/adm/admavatar.php

Attachment: acp.zip
(Size: 22.06KB, Downloaded 1050 times)

Report message to a moderator

[Message index]

		FUDforum and valid HTML By: JanRei on Tue, 05 September 2006 22:01
		Re: FUDforum and valid HTML By: Ilia on Wed, 06 September 2006 15:04
		Re: FUDforum and valid HTML By: JanRei on Thu, 07 September 2006 18:42
		Re: FUDforum and valid HTML By: Ilia on Fri, 08 September 2006 15:19
		Re: FUDforum and valid HTML By: JanRei on Fri, 08 September 2006 15:52
		Re: FUDforum and valid HTML By: Ilia on Fri, 08 September 2006 15:53
		Re: FUDforum and valid HTML By: JanRei on Fri, 08 September 2006 16:15
		Re: FUDforum and valid HTML By: Ilia on Mon, 11 September 2006 13:48
		Re: FUDforum and valid HTML By: JanRei on Mon, 11 September 2006 14:10
		Re: FUDforum and valid HTML By: Ilia on Mon, 11 September 2006 19:06
		Re: FUDforum and valid HTML By: JanRei on Sun, 10 September 2006 16:22
		Re: FUDforum and valid HTML By: Ilia on Mon, 11 September 2006 13:46
		Re: FUDforum and valid HTML By: JanRei on Mon, 11 September 2006 19:54
		Re: FUDforum and valid HTML By: Ilia on Mon, 11 September 2006 20:08
		Re: FUDforum and valid HTML By: JanRei on Wed, 13 September 2006 22:24
		Re: FUDforum and valid HTML By: Ilia on Thu, 14 September 2006 19:16
		Re: FUDforum and valid HTML By: JanRei on Fri, 29 December 2006 16:18
		Re: FUDforum and valid HTML By: Ilia on Mon, 01 January 2007 18:16
		Re: FUDforum and valid HTML By: JanRei on Tue, 02 January 2007 22:40
		Re: FUDforum and valid HTML By: Ilia on Wed, 03 January 2007 23:38
		Re: FUDforum and valid HTML By: JanRei on Thu, 04 January 2007 17:59
		Re: FUDforum and valid HTML By: Ilia on Fri, 05 January 2007 00:33
		Re: FUDforum and valid HTML By: JanRei on Wed, 10 January 2007 21:14
		Re: FUDforum and valid HTML By: Ilia on Fri, 12 January 2007 02:14

Previous Topic:	FUDForum hard to install
Next Topic:	fud_delete_user() produces SQL error?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Wed Nov 27 08:34:06 GMT 2024

Total time taken to generate the page: 0.03863 seconds