| My first patch on 1.2.7 [message #1570] |
Thu, 18 April 2002 22:28  |
mauftarkie
Messages: 29
Registered: April 2002
Karma: 0
|
Junior Member |
add to buddy list
ignore all messages by this user
|
|
Just hoping to give back to the community a little because I really like this software. This short patch:
- fixes mispelling of "Announcement" in post.php
- fixes no-birthday registration bug in register.php. If the registering user leaves the birthday field blank when registering, a default date would get set (January 1, 2000 is what it did on my system). This patch eliminates that and the birthday remains unset in this scenario.
- added "(URL)" to "Image:" and "Homepage:" rows in register.php. I was a little confused what I was supposed to do with the image textfield at first, and I imagine others will as well. The addition to the homepage text is just for the sake of completeness.
- removed stray control characters from confirmation.msg.
- uppercased the word "URL" where it is shown to the user in various mail messages to keep consistancy.
More to follow, I'm sure. I ran/edited the patch from a fresh uninstalled tar dump.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Patch #3 [message #1728 is a reply to message #1618] |
Sun, 21 April 2002 18:47  |
mauftarkie
Messages: 29
Registered: April 2002
Karma: 0
|
Junior Member |
add to buddy list
ignore all messages by this user
|
|
Today's megapatch against 1.2.x-cvs is my first attempt to make the admin global configuration screen a little more user friendly. Take or leave it if you like. This patchset also includes some more spelling corrections, some applied consistancy for acronyms, and some links to explain what COPPA is (I had heard about it, but didn't really know about it). Lastly, it also includes the birthday fix in util.inc from earlier today (if you haven't applied it yet).
I did notice a strange bug, though, that I haven't had time to track down yet. Maybe you can explain and/or fix it faster than I can. In the admin global config screen, if you type an option value with quotes (ex. "test") and submit the form, you cannot get rid of that value from that point on. If you try to submit a blank field, it comes back. If you try to erase and give another value, the new value is appended to the quoted value!
Aargh!
Oh, and in forum_rules13.msg, is the sentence "A copy of the permission form can be downloaded here" supposed to point to anything? I know the form that they can print out is generated if they submit the form, but what if they don't want to start the registration process?
Cheers!
|
|
|
|
| Re: My first patch on 1.2.7 [message #1729 is a reply to message #1728] |
Sun, 21 April 2002 19:52 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
remove from buddy list
ignore all messages by this user
|
|
The util.inc has already been fixed in CVS, thanks for the patch.
I'll look over the other patches and let you know what did & did not go in.
The bug with the admin form, the quoted values is actually the fault of the regex that parses that file. I will be re-writing it for FUDforum 2.0 shortly, so I'll backport it to 1.2X as well.
FUDforum Core Developer
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Patch #3 [message #1761 is a reply to message #1728] |
Mon, 22 April 2002 14:44 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
remove from buddy list
ignore all messages by this user
|
|
| mauftarkie wrote on Sun, 21 April 2002 6:47 PM |
I did notice a strange bug, though, that I haven't had time to track down yet. Maybe you can explain and/or fix it faster than I can. In the admin global config screen, if you type an option value with quotes (ex. "test") and submit the form, you cannot get rid of that value from that point on. If you try to submit a blank field, it comes back. If you try to erase and give another value, the new value is appended to the quoted value!
|
I rewrote the code which parses/edits GLOBALS.php file it is now regex free, thus quite a bit faster. In addition it solves the bug you've mentioned.
FUDforum Core Developer
|
|
|
|
|
|
|
|
|
|
Calendar
Search
Help
Members
Control Panel
Logout [ CommonCrawl [Bot] ]
Home
]