| Moving single posts [message #33608] |
Sat, 09 September 2006 17:24  |
Atthar
Messages: 16
Registered: July 2006
Location: Iran/Tehran
Karma: 0
|
Junior Member |
add to buddy list
ignore all messages by this user
|
|
some times forum admin need to moving a single post to another topic, i think fud forum must have this feature.
in [show what people are doing}, ip of unregistered users must be approve to admin. also name of spiders must be know to admin (or all users).
thank you
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Moving single posts [message #33646 is a reply to message #33643] |
Mon, 11 September 2006 16:10  |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
add to buddy list
ignore all messages by this user
|
|
| JanRei wrote on Mon, 11 September 2006 16:08 |
I think a feature for moving single topics could save needed mouse clicks and time. So it could simplify the procedure.
|
You can already move an entire topic with move button to another forum very easily or merge with another topic via merge topic.
| Quote: |
Locking single messages could be useful if you want to prevent users to edit their posts after being edited by a moderator.
|
Forum already allows it, via "edit time" after it passed the author can no longer edit his own messages.
FUDforum Core Developer
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Moving single posts [message #33808 is a reply to message #33665] |
Fri, 22 September 2006 10:22 |
|
|
| Ilia wrote on Tue, 12 September 2006 17:49 |
Moving message from one topic to another is something to consider for 2.7.7.
|
Great! This is a very important feature for me.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Moving single posts [message #35415 is a reply to message #35391] |
Tue, 09 January 2007 05:35 |
|
|
| JanRei wrote on Sat, 06 January 2007 20:36 |
First I would like to suggest that the topic hasn't be to selected by giving in the topic ID. I think that this makes it easy to make mistakes/typos and moving the messages to a wrong topic.
|
I have experience with such a method on our old handmade forum and I want to say, that's pretty comfortable. I've never had a mistakes. Moderator just have to be little attentive, that's all :)
|
|
|
|
|
|
| Re: Moving single posts [message #35419 is a reply to message #35416] |
Tue, 09 January 2007 09:31 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
add to buddy list
ignore all messages by this user
|
|
| Ernesto wrote on Tue, 09 January 2007 07:38 |
Instead of topic ID, make a list of topics, just as on the thread page, showing the default number of topics per page.
Make it a stairway selection - First categroy (subcategory) and then list the topics, X per page. Only need to list topic title, topic starter and date.
|
That's way too complex.
FUDforum Core Developer
|
|
|
|
| Re: Moving single posts [message #35420 is a reply to message #35414] |
Tue, 09 January 2007 09:33 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
add to buddy list
ignore all messages by this user
|
|
| JanRei wrote on Mon, 08 January 2007 18:12 |
I understand your point. But I think selecting the target topic via its ID is likely to produce mistakes. I also don't know if your way is more pratical because the topic ID is nowhere displayed in the forum and moderators would have to study the link to a topic to get the ID from there.
There seem to be some problems with your implementation. I have tried to give in a invalid ID (a topic ID that does not exist) and I got to blank page. The reason seems to be the following error:
| Quote: |
PHP Fatal error: Call to undefined function check_return() in C:\xampp\htdocs\forum\theme\default\movemsg.php on line 363
|
Then I tried to move messages while only being a moderator and I got a blank page instead of the moving messages menu. The problem seems to be the following querry error:
| Quote: |
(C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\index.php:171
C:\xampp\htdocs\forum\theme\default\movemsg.php:338
C:\xampp\htdocs\forum\index.php:1194
) 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5
Query: SELECT mm.id, COALESCE(g2.group_cache_opt, g1.group_cache_opt) AS gco FROM fud26_thread t LEFT JOIN fud26_mod mm ON mm.user_id=3 AND mm.forum_id=t.forum_id INNER JOIN fud26_group_cache g1 ON g1.user_id=2147483647 AND g1.resource_id=t.forum_id LEFT JOIN fud26_group_cache g2 ON g2.user_id=3 AND g2.resource_id=t.forum_id WHERE t.id=
_GET: array ( 't' => 'movemsg', 'th' => '1', )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/index.php?t=msg&th=1&start=0&S=20b6e6d08 675aed8e6442e7d3e57fd67
|
I also found the following warning in my error log, but I don't know under what condition it occurs:
| Quote: |
PHP Warning: in_array() [<a href='function.in-array'>function.in-array</a>]: Wrong datatype for second argument in C:\xampp\htdocs\forum\theme\default\movemsg.php on line 390
|
|
Both of the described issues are now fixed in CVS.
FUDforum Core Developer
|
|
|
|
|
|
| Re: Moving single posts [message #35422 is a reply to message #35420] |
Tue, 09 January 2007 15:18 |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
remove from buddy list
ignore all messages by this user
|
|
| Ilia wrote on Tue, 09 Januar 2007 15:33 |
Both of the described issues are now fixed in CVS.
|
Great, I have applied the patch and it works indeed. But what's about the warning about in_array (now in line 409), can it be ignored?
When I want to move messages to a deleted topic, I get "You do not have the required permissions to perform this action". I was a little bit surprised since I was a admin at this time.
And the forum seems to have some problems with the message/topic counting:
When I move messages to a topic that is in another forum, the topic count on the index page doesn't seem to get updated.
When I move all messages of a topic to another I get a empty topic with "-1" replies (according to the topic listing).
[Updated on: Tue, 09 January 2007 15:18] Report message to a moderator |
|
|
|
|
|
| Re: Moving single posts [message #35428 is a reply to message #35422] |
Wed, 10 January 2007 11:06 |
Ilia
Messages: 13241
Registered: January 2002
Karma: 0
|
Senior Member
Administrator
Core Developer |
add to buddy list
ignore all messages by this user
|
|
Can you show me a warning, the warning really should not exist unless you somehow found a topic without any messages in it, which is technically impossible.
I fixed the error on a not-found topic to be non-permission related to prevent confusion.
Can you make sure all your message moving code is up to date with CVS and see if you still encounter the counter problem. I do not appear to have it here locally.
FUDforum Core Developer
|
|
|
|
|
|
|
|
| Re: Moving single posts [message #35456 is a reply to message #33608] |
Fri, 12 January 2007 11:02 |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
remove from buddy list
ignore all messages by this user
|
|
Now I get some query errors:
| Quote: |
(C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:415
C:\xampp\htdocs\forum\index.php:1194
) 1054: Unknown column 'last_post_date' in 'field list'
Query: UPDATE fud26_forum SET post_count=post_count+2, last_post_date=1168616130, last_post_id=3, last_post_id=3 WHERE id=2
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => 'e59c8cd9c612d21b06de0a0b8c198bed', 'SQ' => '0c321c58dbaca399f964cd14cb5effb2', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '3', ), )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg
|
| Quote: |
(C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:439
C:\xampp\htdocs\forum\index.php:1194
) 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '0) WHERE id=1' at line 1
Query: UPDATE fud26_forum SET post_count=MAX(post_count-1,0) WHERE id=1
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => 'e59c8cd9c612d21b06de0a0b8c198bed', 'SQ' => '6e29e03d399f6fd42cd892e474fec1a9', 'th' => '2', 'dest_th' => '1', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', ), )
Server Version: 5.0.21-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=2
|
|
|
|
|
|
|
| Re: Moving single posts [message #35472 is a reply to message #33608] |
Sun, 14 January 2007 14:57 |
JanRei
Messages: 361
Registered: October 2005
Location: Germany
Karma: 0
|
Senior Member
Contributing Core Developer
Translator |
remove from buddy list
ignore all messages by this user
|
|
I still get the first query error:
| Zitat: |
(C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:415
C:\xampp\htdocs\forum\index.php:1194
) 1054: Unknown column 'last_post_date' in 'field list'
Query: UPDATE fud26_forum SET post_count=post_count+2, last_post_date=1168798990, last_post_id=7, last_post_id=7 WHERE id=2
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '69f262f1b06aee9a9f211da37f01ea37', 'SQ' => '244967d5871f0716cbb08ab06e37492a', 'th' => '3', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '6', 1 => '7', ), )
Server Version: 5.0.27-community
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=3
|
And this one seems to be new:
| Zitat: |
(C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\index.php:135
C:\xampp\htdocs\forum\theme\default\movemsg.php:423
C:\xampp\htdocs\forum\index.php:1194
) 1146: Table 'fudforum.fud26__tv_1' doesn't exist
Query: SELECT t.last_post_id FROM fud26__tv_1 v INNER JOIN fud26_thread t ON t.id=v.thread_id WHERE tv_seq=1
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '69f262f1b06aee9a9f211da37f01ea37', 'SQ' => '3a5da9b27ecf6ab5a254537b857f4135', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '2', ), )
Server Version: 5.0.27-community
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=1
|
|
|
|
|
|
|
|
|
Calendar
Search
Help
Members
Control Panel
Logout [ CommonCrawl [Bot] ]
Home
]