FUDforum: Bug Reports » NNTP Import Subject with Non-Ascii Characters

Home » FUDforum Development » Bug Reports » NNTP Import Subject with Non-Ascii Characters

Show: Today's Messages :: Unread Messages :: Polls :: Message Navigator
| Subscribe to topic | Bookmark topic

NNTP Import Subject with Non-Ascii Characters [message #165125]

Thu, 28 April 2011 07:35

jm2morri

Messages: 225
Registered: January 2009
Location: Stratford, Ontario, Canad...

Karma: 0

Senior Member

add to buddy list
ignore all messages by this user

There still seems to be a problem with subjects that have non-ascii characters. E.g.

http://www.eaglecentral.ca/forums/index.php?t=msg&goto=137722&S=2ba c665fd7aef3392e70dde94c5b1157#msg_137722

The subject has a TM symbol in it and when importing FUDForum just gave up I guess. I've had user's complain that german characters don't show up properly in the subject as well, which is probably the same issue.

I can send the original newsgroup to anyone who's interested looking at it. Frank, it's e.sup.e in my normal newsgroups. The groups are sort of off the beaten path and I don't want to attract spammers by posting it here in plain text Smile

Cheers,

James

Report message to a moderator

Rate author: +1 -1

Re: NNTP Import Subject with Non-Ascii Characters [message #165126 is a reply to message #165125]

Thu, 28 April 2011 07:38

jm2morri

Messages: 225
Registered: January 2009
Location: Stratford, Ontario, Canad...

Karma: 0

Senior Member

add to buddy list
ignore all messages by this user

Quick update...

That link will now have the right subject--I edited it by hand. It did say "(no subject)" without the quotes.

James.

Report message to a moderator

Rate author: +1 -1

Re: NNTP Import Subject with Non-Ascii Characters [message #165135 is a reply to message #165126]

Mon, 02 May 2011 12:17

naudefj

Messages: 3775
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

remove from buddy list
ignore all messages by this user

Can you please send me the message id?
I've imported the group, but cannot find that particular message.

Report message to a moderator

Rate author: +1 -1

Re: NNTP Import Subject with Non-Ascii Characters [message #165136 is a reply to message #165135]

Mon, 02 May 2011 12:50

naudefj

Messages: 3775
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

remove from buddy list
ignore all messages by this user

Got it. Thanks for the mail. Here is the patch against nntp.php:

@@ -260,7 +260,7 @@
 		}
 
 		fud_wordwrap($msg_post->body);
-		$msg_post->subject = htmlspecialchars(apply_custom_replace($emsg->subject));
+		$msg_post->subject = apply_custom_replace($emsg->subject);
 		if (!strlen($msg_post->subject)) {
 			log_script_error('Blank subject', $emsg->raw_msg);
 			$msg_post->subject = '(no subject)';

Report message to a moderator

Rate author: +1 -1

Re: NNTP Import Subject with Non-Ascii Characters [message #165138 is a reply to message #165136]

Mon, 02 May 2011 13:22

jm2morri

Messages: 225
Registered: January 2009
Location: Stratford, Ontario, Canad...

Karma: 0

Senior Member

add to buddy list
ignore all messages by this user

Implemented that fix, see test thread here

http://www.eaglecentral.ca/forums/index.php?t=msg&goto=137833&S=438 90b1c15605d9487de9763ace80280#msg_137833

Initial message was posted through website and it showed in Thunderbird reading the NNTP server directly. The reply was composed in Thunderbird and then imported into the FUDforum. It didn't stall this time (which is an improvement) but it stripped out the TM symbol. The TM symbol is in the subject line in Thunderbird. You can find that in the test forum at the same news server....

James.

James.

Report message to a moderator

Rate author: +1 -1