FUDforum
Fast Uncompromising Discussions. FUDforum will get your users talking.

Home » FUDforum Development » Plugins and Code Hacks » Newbie question: where to check in bug fix on sourceforge?
Show: Today's Messages :: Unread Messages :: Polls :: Message Navigator
| Subscribe to topic | Bookmark topic 
Switch to threaded view of this topic Create a new topic Submit Reply
Message by DPhan is ignored  [reveal message]  [reveal all messages by DPhan]  [stop ignoring this user] Go to next message
Re: Newbie question: where to check in bug fix on sourceforge? [message #167711 is a reply to message #167709] Wed, 05 September 2012 01:36 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
See trunk/install/forum_data/scripts/fudapi.inc.php

Procedure to check in code is at SVN.

However, before we give you access, can you please post the patch here for verrification?
Re: Newbie question: where to check in bug fix on sourceforge? [message #167717 is a reply to message #167711] Wed, 05 September 2012 13:49 Go to previous messageGo to next message
DPhan is currently offline  DPhan   United States
Messages: 9
Registered: September 2012
Location: San Jose, Calif
Karma: 0
Junior Member
add to buddy list
stop ignoring messages by this user
The problem was the lack the quote characters for the registration_ip in the SQL insert statement in the function fud_add_user()

diff -u fudapi.inc.php-orig fudapi.inc.php

--- fudapi.inc.php-orig 2012-09-05 10:44:14.000000000 -0700
+++ fudapi.inc.php 2012-09-05 10:44:19.000000000 -0700
@@ -722,7 +722,7 @@
'. ssn(htmlspecialchars($vals['home_page'])) .',
'. ssn($vals['bio']) .',
'. (int)$vals['users_opt'] .',
- '. $vals['registration_ip'] .'
+ \''. $vals['registration_ip'] .'\'
)
');
}
Re: Newbie question: where to check in bug fix on sourceforge? [message #167718 is a reply to message #167717] Thu, 06 September 2012 01:57 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Looks good.

Please register a users on SourceForge.net so we can grant you commit access.
Message by DPhan is ignored  [reveal message]  [reveal all messages by DPhan]  [stop ignoring this user] Go to previous messageGo to next message
Re: Newbie question: where to check in bug fix on sourceforge? [message #167723 is a reply to message #167720] Fri, 07 September 2012 09:53 Go to previous messageGo to next message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
You cannot keep it private. Once we grant you access, SourceForge will identify you as a FUDforum developer.
Message by DPhan is ignored  [reveal message]  [reveal all messages by DPhan]  [stop ignoring this user] Go to previous messageGo to next message
Re: Newbie question: where to check in bug fix on sourceforge? [message #167729 is a reply to message #167725] Sat, 08 September 2012 11:57 Go to previous message
naudefj is currently offline  naudefj   South Africa
Messages: 3771
Registered: December 2004
Karma: 28
Senior Member
Administrator
Core Developer
add to buddy list
ignore all messages by this user
Access was granted.
Quick Reply
Formatting Tools:   
  Switch to threaded view of this topic Create a new topic
Previous Topic: Add a canonical link to the message page
Next Topic: Code fix for the fatal division by zero error if moderator uses "move selected" button
Goto Forum:
  

-=] Back to Top [=-
[ Syndicate this forum (XML) ] [ RSS ]

Current Time: Wed Nov 13 09:55:07 EST 2024

Total time taken to generate the page: 0.03661 seconds