FUDforum: Plugins and Code Hacks » Proposed code change to add AUTO

Home » FUDforum Development » Plugins and Code Hacks » Proposed code change to add AUTO_LOGIN plugin hook

Show: Today's Messages :: Unread Messages :: Polls :: Message Navigator
| Subscribe to topic | Bookmark topic

Proposed code change to add AUTO_LOGIN plugin hook [message #184653]

Tue, 14 January 2014 11:26

kmoradha
Messages: 8
Registered: January 2014

Karma: 0

Junior Member

add to buddy list
ignore all messages by this user

This code change adds a new plugin hook named "AUTO_LOGIN" to allow automatic user login based on external authentication methods. We are currently using this in combination with a Basic Authentication configuration on the web server.

The plugin hook is only used if a saved session is not initially identifiable, and before an anonymous session is created.

Please review the code change below:

--- users.inc.t-orig    2014-01-14 11:08:47.608988091 -0500
+++ users.inc.t 2014-01-14 11:13:50.702268354 -0500
@@ -655,6 +655,11 @@
        $sq = 0;
        /* Fetch an object with the user's session, profile & theme info. */
        if (!($u = ses_get())) {
+               /* Call auto-login plugins. */
+               $u = plugin_call_hook('AUTO_LOGIN');
+       }
+
+       if (!$u) {
                /* New anon user. */
                $u = ses_anon_make();
        } else if ($u->id != 1 && (!$GLOBALS['is_post'] || sq_check(1, $u->sq, $u->id, $u->ses_id))) {

Report message to a moderator

Rate author: +1 -1

Re: Proposed code change to add AUTO_LOGIN plugin hook [message #184654 is a reply to message #184653]

Tue, 14 January 2014 12:23

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

add to buddy list
ignore all messages by this user

Would it be possible to maybe use the AUTHENTICATE hook for this?

Quote:

Authenticate users against an external source like an LDAP directory. Example implementation: Email_login.plugin and Ldap.plugin.

Report message to a moderator

Rate author: +1 -1

Re: Proposed code change to add AUTO_LOGIN plugin hook [message #184655 is a reply to message #184654]

Tue, 14 January 2014 12:31

kmoradha
Messages: 8
Registered: January 2014

Karma: 0

Junior Member

add to buddy list
ignore all messages by this user

No, the AUTHENTICATE hook occurs after the user has submitted login credentials into the login form. The purpose of this hook is to prevent the need for the login form altogether, to be used when user authentication can be done using some external factor (such as Basic auth that might be configured with a single sign-on solution).

Report message to a moderator

Rate author: +1 -1

Re: Proposed code change to add AUTO_LOGIN plugin hook [message #184656 is a reply to message #184654]

Tue, 14 January 2014 12:39

naudefj

Messages: 3771
Registered: December 2004

Karma: 28

Senior Member
Administrator
Core Developer

add to buddy list
ignore all messages by this user

OK, maybe not. AUTHENTICATE is in 'login.php.t' and you want to authenticate users without going through the login dialogue.

Maybe just add the following so clutch out all plugins and commit:

if (defined('plugins')) {

Report message to a moderator

Rate author: +1 -1

Re: Proposed code change to add AUTO_LOGIN plugin hook [message #184657 is a reply to message #184656]

Tue, 14 January 2014 12:43

kmoradha
Messages: 8
Registered: January 2014

Karma: 0

Junior Member

add to buddy list
ignore all messages by this user

Just to be sure, here's how I interpret that:

--- users.inc.t-orig    2014-01-14 11:08:47.608988091 -0500
+++ users.inc.t 2014-01-14 12:42:28.902660593 -0500
@@ -654,7 +654,12 @@

        $sq = 0;
        /* Fetch an object with the user's session, profile & theme info. */
-       if (!($u = ses_get())) {
+       if (!($u = ses_get()) && defined('plugins')) {
+               /* Call auto-login plugins. */
+               $u = plugin_call_hook('AUTO_LOGIN');
+       }
+
+       if (!$u) {
                /* New anon user. */
                $u = ses_anon_make();
        } else if ($u->id != 1 && (!$GLOBALS['is_post'] || sq_check(1, $u->sq, $u->id, $u->ses_id))) {

Report message to a moderator

Rate author: +1 -1