|
|
|
|
|
|
|
|
|
|
|
|
| Re: Aw: various validation and cosmetic issues |
Tue, 16 February 2010 12:27 |
|
|
Hi Jan,
Looks good. You can commit it. The only possible improvement is to include {header_plain} (from header.tmpl) in coppa_fax.tmpl. But if you cannot, it is fine as-is.
Best regards.
Frank
|
|
| Re: Aw: various validation and cosmetic issues |
Tue, 16 February 2010 11:36 |
|
|
Yes, this seems to cover most of the patches. I came across some additional things and attached a new patch. It should fix some some small typos and validation issues. Apart from that I added access keys for previewing and submitting quick reply.
I also committed the changes for the German help now.
|
|
|
|
| Re: Aw: various validation and cosmetic issues |
Sat, 13 February 2010 08:04 |
|
|
Hi Jan,
You can commit bordusage_german.diff.
I will review the rest later. For example, we need to remove the popup header from admbrowse.php and reuse the header in header.php. Maybe something like:
define('popup',1);
include header.php;
...
include footer.php;
Best regards.
Frank
|
|
| Aw: various validation and cosmetic issues |
Thu, 11 February 2010 17:08 |
|
|
I merged your changes with mine and it seems that these changes were not applied (see remaining_changes.diff):
- IP Browser: charset issue with error message returned by fsockopen (probably this issue also affects only Windows)
- Forum Statistics: fix some notices
- Icon selection: fix some warnings
- Replacement and Censorship System: fix some validation issues
- Calendar: small validation fix
- File Administration System: add year to date information; improve XHTML validity of popup window
The installer still aborts on my system while setting up MySQL tables. I think it could be related to file endings of def_calendar.sql because after converting it to the Linux format it seems to work fine. Maybe you could have look at it.
Apart from that I attached also a patch for the German help files to incorporate the updates for the section about access keys (see bordusage_german.diff).
|
|
|
|
|
|
|
|
| Re: Aw: various validation and cosmetic issues |
Tue, 02 February 2010 06:03 |
|
|
|
Thank Jan! I always enjoy reviewing your patches. It's good to have a second pair of eyes on the code. I am relatively swamped at this moment, please allow a week or two for me to work through all your changes.
|
|
| Aw: various validation and cosmetic issues |
Mon, 01 February 2010 14:39 |
|
|
I have been very silent lately, sorry for that. Over the last days I had a closer look at the current development version. I prepared a patch that incorporates some suggestions and fixes. Hopefully they are regarded as helpful.
First I noticed that the installation fails because of SQL syntax errors related to the calendar. It seems that MySQL doesn't like "desc" as column name because it is a reserved keyword. I renamed it to "evtdesc" for now - not sure whether it is a good name, but at least it fixes the issue for me. I also converted def_calendar.sql to Unix file endings because it seems the installer can parse this better then.
Apart from that the following changes are included in the patch:
General
- fix various validation issues and typos
- attempt to fix some charset issues and problems with %e modifier for strftime on Windows
Forum
- fix some warnings and notices during registration and while moving of topics
- sync default smiley cache with default content of the database
- Find User: enlarge window so that page fits also with German localization without scroll bars
- Avatar Selection Form: make button translatable
- Moderation Queue: attempt to make some visual improvements
- Calendar: get month names from locale and make a button translatable
- changed search in forum header so that Opera shows description for "F" access key
Admin Control Panel
- don't throw JavaScript error if no H2 element is present on page
- Forum Statistics: fix some notices
- Icon selection: fix some warnings
- Orphaned Forums: don't show "Reassign" button if there are no categories
- MIME/Avatar/Smiley Management System: improve loading of preview image via JavaScript
- User Administration System: use salt when changing passwords
- Filters (E-mail, IP, Login, File): Improved and unified display of defined filters
- MySQL Character Set Adjuster: Show success message after conversion is done
- Add user: fix error handling
- Message Editor: fix downloading of messages from TranslateWiki
- File Administration System: improve error handling while removing of directories; add year to date information; hide Owner/Group columns on Windows
Plugins
- don't use LDAP plugin in case it is not supported by PHP installation (attempt to avoid fatal PHP error during login that could be triggered because of undefined ldap_* functions)
Help
- Access Keys: Updated section regarding browser support and added "F" key for forum search
|
|
|
|
| Re: various validation and cosmetic issues |
Wed, 11 November 2009 15:59 |
|
|
Thank you for making me a project member.
I have tried to commit the mentioned changes and hopefully I haven't made mistakes. It has been the first commit I ever made.
|
|
| Re: various validation and cosmetic issues |
Wed, 11 November 2009 12:29 |
|
|
Hi Jan,
These are all good changes.
I've granted you commit access to the SF repository. You are welcome to commit these yourself. If you don't get to it, I'll do it later this week.
PS: Commit instruction are on the wiki at SVN.
Best regards.
Frank
|
|
| Re: various validation and cosmetic issues |
Tue, 10 November 2009 18:39 |
|
|
Do you think that the mentioned change concerning __adm_rsid in install/forum_data/include/adm.inc can be reverted now? Like I said it would fix some validation issues. I hope the problems with the pop-ups has been fixed with my previous patches.
On this occasion I would like to mention some smaller problems I have noticed in the meantime:
1) It seems that the English theme misses an default value for text direction. During theme compilation the following warning appears:
Quote:Warning: file_get_contents(E:/xampp/htdocs/FUDforum/thm/default/i18n/english/dir) [<a href='function.file-get-contents'>function.file-get-contents</a>]: failed to open stream: No such file or directory in E:\xampp\htdocs\FUDforum\include\compiler.inc on line 682
2) I think create_file_list should be adjusted to keep SVN information out of the installer archive:
Index: create_file_list
===================================================================
--- create_file_list (revision 4862)
+++ create_file_list (working copy)
@@ -28,7 +28,7 @@
}
while (($f = readdir($d))) {
- if ($f == '.' || $f == '..' || $f == 'CVS') continue;
+ if ($f == '.' || $f == '..' || $f == '.svn') continue;
if (is_file($v . "/" . $f)) {
$fdata = file_get_contents($v . "/" . $f); |
|
|
|
| Re: various validation and cosmetic issues |
Thu, 22 October 2009 20:28 |
|
|
The issue seems to be with pop-ups opened in File Manager. It looks like we shouldn't encode & as & when setting window.opener.location because this value seems to be used directly for the HTTP request.
I have attached a patch that makes the corresponding changes hopefully it will fix the problem.
admbrowse.diff
- don't encode & when setting window.opener.location
- fix time shown in directory listing (Windows does not seem to know %T)
header.diff
- fix charset declaration in Admin Control Panel
admaccapr.diff
- attempt to improve the information shown on account approval
index.diff, admplugins.diff
- fix validation problems
|
|
| Re: various validation and cosmetic issues |
Wed, 21 October 2009 02:01 |
|
|
|
If I remember correctly the change allowed some of the pop-up windows to return to their corresponding control panels instead of exiting the ACP completely. How do we proceed with this?
|
|
| Re: various validation and cosmetic issues |
Tue, 20 October 2009 15:22 |
|
|
I don't want to open a new topic for it. May I ask why this was changed in install/forum_data/include/adm.inc (1.43 -> 1.44)?
- define('__adm_rsid', _rsidl.'&SQ='.$GLOBALS['sq']);
+ define('__adm_rsid', _rsidl.'&SQ='.$GLOBALS['sq']);
This change seems to cause some validation errors, because the & should be encoded as &. Also, __adm_rsid and __adm_rsidl are the same now.
|
|
|
|
| Re: various validation and cosmetic issues |
Tue, 13 October 2009 19:32 |
|
|
I hope I can re-use this topic for some further patches that mostly deal with some warnings shown on a shared hosting environment.
install.php
- Surpress a warning related to realpath() call in line 1085 that could be shown in case open_basedir restrictions are in effect.
- Fixed a minor typo.
admplugins.diff
- Surpress a warning related to ini_set() call in line 13. The function could be disabled.
admsysinfo.diff
- Surpress a warning related to php_uname() in line 47. The function could be disabled.
- Introduce spaces into the enumeration of disabled functions so browsers can break the lines.
mem_limit.diff
- Surpress a warning related to ini_set() call in line 17. The function could be disabled.
|
|
|
|
| Re: various validation and cosmetic issues |
Sat, 16 May 2009 03:54 |
|
|
Many thanks for the patches:
* widgets.inc - applied
* admmysql.php - applied
* admannounce.php - applied
* admplugins.php - applied
* consist.php - applied
* admclose.html - variation applied
* admsql.php - not applied. We cannot use mysql_query as it will break pgsql & sqlite support. Patch needs re-factoring.
Do you mind if we leave this for the 2.8.2 release?
* index.tmpl
* msg
Best regards.
Frank
|
|
| Re: various validation and cosmetic issues |
Fri, 15 May 2009 19:37 |
|
|
I am currently looking trough the Admin Control Panel and found some small issues. This are the results I have so far:
widgets.inc
- make creation of checkboxes XHTML compliant
admmysql.php
- fix a typo
admannounce.php, admplugins.php, consist.php
- fix validation problems
admclose.html
- W3C validator is confused by the JavaScript, enclose it in comments
index.tmpl, msg
- suggestion for visually improved display of forums with url redirection
admsql.php
- some improvements to the output of the SQL Manager (better error messages and prevent large results running off the screen)
|
|
|
|
| Re: various validation and cosmetic issues |
Thu, 02 April 2009 16:04 |
|
|
|
Yes, it was. I think the JavaScript is related to ICQ notifications that have been removed from FUDforum some time ago since they were not working properly. Apart from that, the JavaScript caused a validation error on that page.
|
|
|
|
| Re: various validation and cosmetic issues |
Wed, 01 April 2009 17:48 |
|
|
|
I don't think ps_cache and sp_cache are related to an old installation sincy my patches should be based on a fresh installation of FUDforum. It looks like there are default smiley caches in CVS.
|
|
| Re: various validation and cosmetic issues |
Wed, 01 April 2009 16:56 |
|
|
Wow, I'm impressed. Sincere thanks for your time and effort. I will start committing your patches tomorrow.
PS: The only two that cannot be committed is ps_cache and sp_cache. These files are not re-created when you upgrade. You may still have some old files from prior versions on your system.
Best regards.
Frank
|
|
| various validation and cosmetic issues |
Wed, 01 April 2009 16:20 |
|
|
I have noticed some validation issues (particular within user control panel, help and post form) and tried to fix them. While being at it I also made some cosmetic changes. You will find a detailed list of suggested changes below and the corresponding patches in the attached archive. Hopefully they are good enough to be included into FUDforum.
There are some things I could not fix. For example, lists ([LIST][*]item[/LIST]) do not seem to be transformed into valid XHTML. Among other things, the W3C validator expects <li> tags to be closed by </li>. Unfortunately I didn't understand fully how these lists are parsed.
drawmsg.diff
- fix some validation issues related to the display of attachments and polls
msg.diff
- small validation fixes
- remove dot from option name (consistency)
- small cosmetic change related to the display of the number of currently attached files
post_common.diff
- fix validation issues related to attachments
- separate max number of files and number of currently attached files by a semicolon
- change Kb to KB (consistency)
ps_cache, sp_cache
- HTML -> XHTML
post_proc.diff
- attempt to fix validation issues related to spoilers
ppost.diff
- show "Private Messaging ยป Writing a Private Message" below the tab row (more consistent in my opinion)
register.diff
- remove a javascript related to the ICQ notifications (not supported anymore as far as I know) which also fixes validation
uc.diff:
- fix validation issues on "Notifications" tab in user control panel
usermaintance.diff, boardusage.diff, readingposting.diff
- some validation fixes
- separate help topics consistently by one empty line
- some changes in help texts to improve consistency a bit
|
|
Calendar
Search
Help
Members
Control Panel
Logout [ CommonCrawl [Bot] ]
Home