|
Re: Moving single posts |
Fri, 19 January 2007 09:54 |
|
This error message seems to be indeed fixed but now I get this one:
Zitat: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\index.php:135
C:\xampp\htdocs\forum\theme\default\movemsg.php:423
C:\xampp\htdocs\forum\index.php:1194
) 1054: Unknown column 'tv_seq' in 'where clause'
Query: SELECT t.last_post_id FROM fud26_tv_1 v INNER JOIN fud26_thread t ON t.id=v.thread_id WHERE tv_seq=1
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => 'ff7e157685c4a03340e93ca6c3dfa3a9', 'SQ' => '7065928e7bc2eb130cc3a34f32be1a64', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '2', ), )
Server Version: 5.0.27-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=1
|
|
|
|
Re: Moving single posts |
Sat, 20 January 2007 08:21 |
|
Now I get this:
Zitat: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:439
C:\xampp\htdocs\forum\index.php:1194
) 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' 0), last_post_id=3 WHERE id=1' at line 1
Query: UPDATE fud26_forum SET post_count=post_count-2, thread_count=MAX(thread_count-1, 0), last_post_id=3 WHERE id=1
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => 'ceb602c425f71492f019bcae37349b7f', 'SQ' => '4d6886e938910bc3a31b8d0653b26383', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '2', ), )
Server Version: 5.0.27-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=1
|
|
|
|
Re: Moving single posts |
Sun, 21 January 2007 14:58 |
|
Hm, I always do a clean install of FUDforum using latest CVS when testing this feature.
I have tested your change and I get the following error:
Zitat: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:439
C:\xampp\htdocs\forum\index.php:1194
) 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE id=2' at line 1
Query: UPDATE fud26_forum SET post_count=post_count-2, thread_count=thread_count-1, last_post_id= WHERE id=2
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '0e2becf197b741021f0a8c1768aede99', 'SQ' => 'c596a0a3c0aa31b708df224e1bbcc9d6', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '2', ), )
Server Version: 5.0.27-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=1
|
|
|
|
Re: Moving single posts |
Tue, 23 January 2007 07:13 |
|
Yes, this is correct the source forum had only 1 topic. And the query error is now fixed.
But I have still the problem that the message count is not updated when I move messsages from one forum to another.
I have attached a screenshot showing that the message count can't be correct.
And also got this error once:
Quote: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\theme\default\movemsg.php:415
C:\xampp\htdocs\forum\index.php:1194
) 1054: Unknown column 'last_post_date' in 'field list'
Query: UPDATE fud26_forum SET post_count=post_count+1, last_post_date=1169552320, last_post_id=6, last_post_id=6 WHERE id=2
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '100ce165449929e23bc3d31e3fecc4e5', 'SQ' => 'baa1a12cb72cda4b3fc790385ade9a7a', 'th' => '4', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '6', ), )
Server Version: 5.0.27-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=4
|
|
|
|
Re: Moving single posts |
Wed, 24 January 2007 13:56 |
|
The problem with updating the message count on the index page still exists.
And there is a new problem:
I move all messages in a topic to another (the target topic is in another forum). After the operation I can't access the new topic, because I get "You have followed an invalid link. Please notify the webmaster how you got here."
In my error log I found this, maybe this is related to this:
Quote: | PHP Notice: Undefined index: msg_tdescr in C:\xampp\htdocs\forum\theme\default\post.php on line 4009
PHP Notice: Undefined variable: msg_tdescr in C:\xampp\htdocs\forum\theme\default\post.php on line 4341
|
|
|
Re: Moving single posts |
Wed, 24 January 2007 18:57 |
|
The variable thing should be fixed. As far as topic access, have you tried running the consistency checker?
|
|
Re: Moving single posts |
Thu, 25 January 2007 02:48 |
|
Yes, running consistency checker fixes both the message count and the topic access.
|
|
Re: Moving single posts |
Thu, 25 January 2007 13:16 |
|
Small update, I think I found the error message that is related to the problem with topic access. Maybe it helps to find a solution to it.
Quote: | PHP Warning: in_array() [<a href='function.in-array'>function.in-array</a>]: Wrong datatype for second argument in C:\xampp\htdocs\forum\theme\default\movemsg.php on line 426
|
|
|
|
Re: Moving single posts |
Fri, 26 January 2007 06:47 |
|
Yes, I can't find any php errors in my log anymore.
But unfortunately it doesn't fix the problems regarding moving complete topics from one forum to another (wrong message counting and no access to destination topic). Can you have look what's wrong here?
|
|
|
Re: Moving single posts |
Tue, 30 January 2007 16:51 |
|
I tried it, but now I get this:
Quote: | (C:\xampp\htdocs\forum\index.php:75
C:\xampp\htdocs\forum\index.php:135
C:\xampp\htdocs\forum\theme\default\movemsg.php:2359
C:\xampp\htdocs\forum\index.php:1194
) 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
Query: SELECT root_msg_id FROM fud26_thread WHERE id=
_GET: array ( 't' => 'movemsg', )
_POST: array ( 'S' => '0e519397384711fa13bbfce6f18f7b2a', 'SQ' => 'a2be1f3bbf4602b9470f4defb3a4a0d7', 'th' => '1', 'dest_th' => '2', 'btn_selected' => 'Move Selected Messages', 'msg_ids' => array ( 0 => '1', 1 => '2', ), )
Server Version: 5.0.27-community-nt
[Referring Page] http://localhost/forum/index.php?t=movemsg&th=1
|
|
|
|
Re: Moving single posts |
Thu, 01 February 2007 16:06 |
|
The query error is solved, but it still doesn't work correctly.
But there are still problems left:
1) The message count on the index page doesn't seem to get updated when I move messages to another forum.
2) When I move a complete topic the destination topic doesn't appear on the topic listing anymore. I can bring it back by running consistency checker, but the forum seems to lose the fist message of the source topic.
|
|
Re: Moving single posts |
Thu, 01 February 2007 18:57 |
|
When you move the 1st message in the topic you effectively destroy the source topic.
|
|
Re: Moving single posts |
Fri, 02 February 2007 01:01 |
|
I don't understand your answer. Moving the first message of a topic works, but moving a complete topic doesn't work (as I described).
|
|
Re: Moving single posts |
Sun, 04 February 2007 11:41 |
|
The topic is very much tied to the 1st message, internally referred to as the root message. When this message goes away, the topic goes away with it, since all the checks and determinations, such as topic's subject are determined based upon.
The functionality introduced is by no means a replacement for "merge topic" feature that is already present, which is what you should be using when trying to move all messages from topic X to topic Y.
|
|
Re: Moving single posts |
Sun, 04 February 2007 12:12 |
|
I don't agree with this explanation. It's the destination topic that vanishes and its root message is not touched.
The root message is removed from the source topic. And this message is not removed by me but by the forum.
|
|
Re: Moving single posts |
Thu, 08 February 2007 15:27 |
|
Are you going to change the behaviour of this feature, Ilia? I would appreciate if you could consider it.
|
|
|
|