Home »
FUDforum Development »
Bug Reports »
Selected and Unselected mix-up?
Selected and Unselected mix-up? [message #20933] |
Wed, 03 November 2004 15:05 |
Abraxa
Messages: 72 Registered: August 2004 Location: Germany
Karma:
|
Member |
|
|
Heya Ilia =)
I don't know if you did it on purpose or not but I found something that made me wonder a little.
In draw_select_opt.tmpl, you define two sections:
{SECTION: selected_option}
<option value="{VAR: vls[$i]}" {VAR: normal_tmpl}>{VAR: nms[$i]}</option>
{SECTION: END}
{SECTION: unselected_option}
<option value="{VAR: vls[$i]}" selected {VAR: selected_tmpl}>{VAR: nms[$i]}</option>
{SECTION: END}
As you can see, the unselected section has the "selected" property while the selected section doesn't - isn't it supposed to be the other way round, judging from the names you gave the sections?
The mix-up doesn't have any consequences since in draw_select_opt.inc.t you do a "!=" comparison instead of "==" but still I wonder if that's something that maybe should be fixed for reasons of code logic?
(btw, same thing occurs in draw_radio_opt.*)
-Abraxa
|
|
|
Goto Forum:
Current Time: Fri Nov 22 06:49:07 GMT 2024
Total time taken to generate the page: 0.04332 seconds